Removing use of subclassed application constant and replacing with Rails.application #10832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more agnostic Rails.application syntax. This means tests will be more portable, and won't rely on the existence of a particular subclass.
josevalim
pushed a commit
that referenced
this pull request
Jun 4, 2013
…onstant Removing use of subclassed application constant and replacing with Rails.application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
Rails.applicationinstead of calling the application constant is a more agnostic syntax. This means tests will be more portable, and won't rely on the existence of a particular subclass. I've changed a bunch of places to use theRails.applicationsyntax.By not calling the
AppTemplate::Applicationconstant, in the future it will be easier to have multiple applications or have applications be given by a particular instance of anApplicationinstead of a subclass.