Added Time#middle_of_day method

[makaroni4]

No description provided.

[sikachu]

I looked at #10878 and still doesn't see a rationale behind this. Would you mind telling us why this is useful to add?

[makaroni4]

@sikachu sure

When one need to make a query relative to middle of the day (for example to show weather data, I faced this situation today) this method might be useful. Also there is Time#midnight method, but no Time#midday.

For sure initializer is a good place for keeping extensions like this, it is not a problem.

[senny]

/cc @pixeltrix

[pixeltrix]

@makaroni4 needs adding to DateTime as well

[pixeltrix]

Thinking about it, adding morning? and afternoon? would be useful too.

[makaroni4]

@pixeltrix thx, I will add midday to DateTime 👍

midday is the opposite of midnight, which difened for Time and DateTime so it is one of the reasons for me to add this method.

There is no opposite method for morning and afternoon (I think it should be smth like midnight) so I think it is a perfect scenario when initializer should be used.

[pixeltrix]

There is past?, future? and today? though which is why I suggested adding morning? and afternoon?. Also missing are tomorrow? and yesterday?.

[killthekitten]

Both hands are up for the tomorrow? and yesterday?

[PavelDemyanenko]

This might be usefull

[schneems]

Interesting, could potentially find this useful. @makaroni4 are you going to add this to DateTime ?

[makaroni4]

Hi, @schneems!

For sure, give me couple of minutes.

[makaroni4]

@pixeltrix @schneems done.

I added methods for both Date and DateTime.

I see duplications of methods like beginning_of_day, end_of_day in Time and DateTime. Should we move them to DateAndDateTime module?

[makaroni4]

@steveklabnik could you please take a look? This one should be either merged or closed 😃

[steveklabnik]

I like to let @pixeltrix merge stuff related to time.

[guilleiguaran]

@pixeltrix aka Kronos, god of the time 😁

[pixeltrix]

@makaroni4 I hadn't merged it yet because the build failed and I thought you might be adding the other methods that had been suggested. No matter - can you check out why the tests are failing and update the PR. There is a significant amount of duplication between DateTime and Time calculations but we'll leave that for another PR.

[makaroni4]

@pixeltrix I see that it was activerecord test failed: Failed components: activerecord:postgresql:isolated.

Could you please restart the build (I probably have no access, because button is locked on Travis)? I have no such an error on my local machine.

[makaroni4]

@pixeltrix the build is green 😄 👍 You rebuilt it or how did it happen?

I will work on DRYing date and time modules in the next PR (as long as tomorrow? and yesterday? methods).

[pixeltrix]

@makaroni4 can you squash the commits - once you've done that I'll merge 👍

[makaroni4]

@pixeltrix the build is failed again due to bundler error in AR tests: https://travis-ci.org/rails/rails/jobs/9582396

[pixeltrix]

@makaroni4 rebuilding that job now - we're nearly there 😄

[makaroni4]

😄

[pixeltrix]

@makaroni4 thanks for you contribution and your patience ❤️

[makaroni4]

Yay! @pixeltrix thank you very much 😃 ❤️

[kirs]

BTW, what about changelog?

[rafaelfranca]

Huge 👍 for CHANGELOG. Added

[makaroni4]

@rafaelfranca sorry, I am late (back to school 😃 )

Thanks a lot for the CHANGELOG 👍