more changes related to @bb43784 ' Removing use of subclassed applicati... #10905

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

...on constant and instead using the'

Rajarshi Das more changes related to @bb43784 ' Removing use of subclassed applic…
…ation constant and instead using the'
b0a8ea3

Hi @arunagw ,

can you please look into this and merge it please?

Thanks

Member

arunagw commented Jun 21, 2013

Please rebase this branch with master

Hi Arun,

Thank you for reply.
Actually I removed the branch so should I again create a branch incorporated these changes?
Please help me
Thanks

Member

arunagw commented Jun 21, 2013

I think you can create a new branch with same name using this SHA "b0a8ea38ae4a87e60804f1cdabe93a33f1f6a9ee"

But if that feel so complicated close this and open a new pull request.

thanks.

Member

steveklabnik commented Jun 22, 2013

All you need to do is to push to your my_new_branch branch on GitHub, and it'll be fine. you may have deleted your local branch, but it's still up on your GitHub.

Member

arunagw commented Jun 22, 2013

And now you need a rebase with master.

Member

arunagw commented Jun 24, 2013

I saw most of these changes are already in master.

Closing this now. Please open a new PR if there are still left.

thanks.

arunagw closed this Jun 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment