Extract ActionView to separate directory #11032

lukaszx0 · 2013-06-20T15:40:49Z

Hey,

This is continuation of work done by @drogus. Basically it moves ActionView outside of ActionPack to its own directory. AV still remains dependency on AP, I will be working on this in coming weeks.

However, after discussing it with @drogus, both of us agreed that it would be good to have those commits in master. (they are basically just moving files, not much changes is code itself) because:

@kaspth is working on his GSoC Loofah project - it touches ActionView so it will be super hard to solve conflicts either for him or me once one of our branches get merged.
It'll be hard for me if somebody will make some changes in master to rebase it.

/cc @pixeltrix @drogus @kaspth

This commit creates structure for Action View gem and is first of a series of commits extracting Action View from Action Pack.

ActionView still relies on ActionPack in some of the tests.

They were moved to actionview/ and are not used in actionpack

kaspth · 2013-06-20T16:09:57Z

Sounds good to me.

rafaelfranca · 2013-06-20T16:16:08Z

lukaszx0 · 2013-06-20T16:17:43Z

Cool. Let me fix few small issues from travis.

robin850 · 2013-06-20T16:31:20Z

actionview/CHANGELOG.md

@@ -0,0 +1,3 @@
+## Rails 4.1.0 (unreleased) ##


Should not be removed since all changelog files don't use it anymore?

Yes, and I think we have to move some entries from the actionpack changelog to here.

rafaelfranca · 2013-06-20T16:41:12Z

An entry on ActionPack CHANGELOG is good too. Maybe we have to review some documentation.

robin850 · 2013-06-20T16:46:49Z

actionview/lib/action_view/version.rb

+module ActionPack
+  # Returns the version of the currently loaded ActionView as a Gem::Version
+  def self.version
+    Gem::Version.new "4.0.0.beta1"


Should be "4.1.0.beta" no? (or at least "4.0.0.rc1")

robin850 · 2013-06-20T16:59:50Z

Hi,

Very nice pull request! ❤️ Is it intended not to put a new line at the end of some files? If it's not the case, here are the concerned files:

actionview/test/fixtures/digestor/messages/show.html.erb
actionview/test/fixtures/fun/games/hello_world.erb
actionview/test/fixtures/good_customers/_good_customer.html.erb
actionview/test/fixtures/shared.html.erb
actionview/test/fixtures/test/_changing_priority.html.erb
actionview/test/fixtures/test/_changing_priority.json.erb
actionview/test/fixtures/test/_counter.html.erb
actionview/test/fixtures/test/_customer.erb
actionview/test/fixtures/test/_customer_greeting.erb
actionview/test/fixtures/test/_customer_with_var.erb
actionview/test/fixtures/test/_first_json_partial.json.erb
actionview/test/fixtures/test/_partial_only.erb
actionview/test/fixtures/test/_raise_indentation.html.erb
actionview/test/fixtures/test/_second_json_partial.json.erb
actionview/test/fixtures/test/hello.builder
actionview/test/fixtures/test/hello/hello.erb
actionview/test/fixtures/test/hello_world.erb

If it's intented, sorry for the spam!

Have a nice day.

lukaszx0 · 2013-06-20T17:17:23Z

Thanks @robin850 and @rafaelfranca for review. I've added few commits above addressing your comments and small things that I've found myself.

Regarding the new line at the end of the file - those files are copied as they were before, in actionpack, nothing's been changed there. I guess that adding new line at the end may break some tests? I don't know. Anyway - it's a matter of style and I don't have opinion on that. It's up to core team.

guilleiguaran · 2013-06-20T19:24:34Z

Looks great for me 👍

@spastorino can be interested in review this also

drogus · 2013-06-20T19:26:47Z

@rafaelfranca any comments on new lines? I don't care to be honest, so if this is not a concern I will merge. I'm pretty sure that there can be things that need improvement here (like: tests are a bit bloated, AV tests using controllers etc), but I would like to merge it soon to not create extra work for @strzalek, like rebasing this branch every few days. We can iterate later.

carlosantoniodasilva · 2013-06-20T19:39:41Z

Changing new lines in those files will likely break tests that check against their output, not expecting the new line at the end. As long as the files were untouched now, I think those changes can be done separately if necessary.

I'm 👍 on moving, this will avoid a lot of possible headache in future work as you guys have described.

rafaelfranca · 2013-06-20T19:41:05Z

No problems with new lines

guilleiguaran · 2013-06-20T19:41:08Z

👍 please don't care about new lines

rafaelfranca · 2013-06-20T19:41:56Z

Well, I think these files should not be removed actionpack/test/fixtures/test/malformed/malformed.html.erb~ and all the ~ files

drogus · 2013-06-20T19:43:01Z

Ok, tests are green, so I'm merging :D

drogus · 2013-06-20T19:43:49Z

@rafaelfranca ah, good catch!

guilleiguaran · 2013-06-20T19:46:29Z

good catch @rafaelfranca, files with ~ are kept intentionally

robin850 · 2013-06-20T20:13:08Z

Sorry for the spam with new lines. ^^

2013/6/20 Guillermo Iguaran notifications@github.com

good catch @rafaelfranca https://github.com/rafaelfranca, files with ~are kept intentionally

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11032#issuecomment-19778448
.

Now if somebody by mistake will remove malformed files test will raise error.

lukaszx0 · 2013-06-20T21:41:13Z

I've restored files and added assert to check if they exist. Next time if @drogus will remove them, he'll be punished by travis ;)

🚢

guilleiguaran · 2013-06-20T21:49:46Z

actionview/test/template/render_test.rb

@@ -376,6 +376,7 @@ def test_render_knows_about_types_registered_when_extensions_are_checked_earlier
  def test_render_ignores_templates_with_malformed_template_handlers
    ActiveSupport::Deprecation.silence do
      %w(malformed malformed.erb malformed.html.erb malformed.en.html.erb).each do |name|
+        assert File.exists?(File.expand_path("#{FIXTURE_LOAD_PATH}/test/malformed/#{name}~")), "Malformed file (#{name}~) which should be ignored does not exists"


👍

some people had tried to send PRs removing the ~ files, I think this makes clear that the files are intentionally kept

drogus · 2013-06-20T22:01:57Z

Next time if @drogus will remove them, he'll be punished by travis ;)

drogus · 2013-06-20T22:42:32Z

TravisCI approves 😎

Extract ActionView to separate directory

lukaszx0 · 2013-06-20T22:45:58Z

spastorino · 2013-06-24T07:11:00Z

👍

drogus and others added 13 commits June 20, 2013 17:23

Add bare actionview gem to the root directory

78b0934

This commit creates structure for Action View gem and is first of a series of commits extracting Action View from Action Pack.

Move actionpack/lib/action_view* into actionview/lib

0d6e8ed

ActionView version should be 4.1.0

5bcdf4f

Move template tests from actionpack to actionview

eb23754

Remove unneeded files

5e5bf31

Add actionpack as actionview's development dependency

b01331e

ActionView still relies on ActionPack in some of the tests.

Remove unneeded test fixtures in AV

f121094

Copy company test fixture to AV (fixes failing test)

c815775

Remove digestor fixtures from AP

3fbc89a

They were moved to actionview/ and are not used in actionpack

Fix digestor tests

6241513

Remove require to AP stuff that left

995e9c4

Template test were moved to AV

f5305e7

Add ActionView to CI

1a62369

Fix isolated tests on AV

194aebb

robin850 reviewed Jun 20, 2013
View reviewed changes

lukaszx0 added 5 commits June 20, 2013 18:59

Change from 'actionpack' to 'actionview' for locales path

d8b0499

Remove heading from AV's CHANGELOG

1d59e94

Adjust changelog for AV & AP

d1fb5d5

Bump up version, fix module name

633f84c

Rename AP to AV in info about running tests

8b57b78

lukaszx0 added 2 commits June 20, 2013 23:35

Restore mistakenly removed malformed file fixtures

08998d2

Check if malformed fixture exists first

d6b1caa

Now if somebody by mistake will remove malformed files test will raise error.

guilleiguaran reviewed Jun 20, 2013
View reviewed changes

drogus added a commit that referenced this pull request Jun 20, 2013

Merge pull request #11032 from strzalek/extract-actionview

a29f746

Extract ActionView to separate directory

drogus merged commit a29f746 into rails:master Jun 20, 2013

lukaszx0 mentioned this pull request Jul 10, 2013

Split out AV from AP, part 2 (WIP) #11396

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract ActionView to separate directory #11032

Extract ActionView to separate directory #11032

lukaszx0 commented Jun 20, 2013

kaspth commented Jun 20, 2013

rafaelfranca commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

robin850 Jun 20, 2013

rafaelfranca Jun 20, 2013

rafaelfranca commented Jun 20, 2013

robin850 Jun 20, 2013

rafaelfranca Jun 20, 2013

robin850 commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

guilleiguaran commented Jun 20, 2013

drogus commented Jun 20, 2013

carlosantoniodasilva commented Jun 20, 2013

rafaelfranca commented Jun 20, 2013

guilleiguaran commented Jun 20, 2013

rafaelfranca commented Jun 20, 2013

drogus commented Jun 20, 2013

drogus commented Jun 20, 2013

guilleiguaran commented Jun 20, 2013

robin850 commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

guilleiguaran Jun 20, 2013

drogus commented Jun 20, 2013

drogus commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

spastorino commented Jun 24, 2013

Extract ActionView to separate directory #11032

Extract ActionView to separate directory #11032

Conversation

lukaszx0 commented Jun 20, 2013

kaspth commented Jun 20, 2013

rafaelfranca commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

robin850 Jun 20, 2013

Choose a reason for hiding this comment

rafaelfranca Jun 20, 2013

Choose a reason for hiding this comment

rafaelfranca commented Jun 20, 2013

robin850 Jun 20, 2013

Choose a reason for hiding this comment

rafaelfranca Jun 20, 2013

Choose a reason for hiding this comment

robin850 commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

guilleiguaran commented Jun 20, 2013

drogus commented Jun 20, 2013

carlosantoniodasilva commented Jun 20, 2013

rafaelfranca commented Jun 20, 2013

guilleiguaran commented Jun 20, 2013

rafaelfranca commented Jun 20, 2013

drogus commented Jun 20, 2013

drogus commented Jun 20, 2013

guilleiguaran commented Jun 20, 2013

robin850 commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

guilleiguaran Jun 20, 2013

Choose a reason for hiding this comment

drogus commented Jun 20, 2013

drogus commented Jun 20, 2013

lukaszx0 commented Jun 20, 2013

spastorino commented Jun 24, 2013