-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Extract ActionView to separate directory #11032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit creates structure for Action View gem and is first of a series of commits extracting Action View from Action Pack.
ActionView still relies on ActionPack in some of the tests.
They were moved to actionview/ and are not used in actionpack
Sounds good to me. |
|
Cool. Let me fix few small issues from travis. |
@@ -0,0 +1,3 @@ | |||
## Rails 4.1.0 (unreleased) ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be removed since all changelog files don't use it anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and I think we have to move some entries from the actionpack changelog to here.
An entry on ActionPack CHANGELOG is good too. Maybe we have to review some documentation. |
module ActionPack | ||
# Returns the version of the currently loaded ActionView as a Gem::Version | ||
def self.version | ||
Gem::Version.new "4.0.0.beta1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "4.1.0.beta"
no? (or at least "4.0.0.rc1"
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.1.0.beta
Hi, Very nice pull request! ❤️ Is it intended not to put a new line at the end of some files? If it's not the case, here are the concerned files:
If it's intented, sorry for the spam! Have a nice day. |
Thanks @robin850 and @rafaelfranca for review. I've added few commits above addressing your comments and small things that I've found myself. Regarding the new line at the end of the file - those files are copied as they were before, in actionpack, nothing's been changed there. I guess that adding new line at the end may break some tests? I don't know. Anyway - it's a matter of style and I don't have opinion on that. It's up to core team. |
Looks great for me 👍 @spastorino can be interested in review this also |
@rafaelfranca any comments on new lines? I don't care to be honest, so if this is not a concern I will merge. I'm pretty sure that there can be things that need improvement here (like: tests are a bit bloated, AV tests using controllers etc), but I would like to merge it soon to not create extra work for @strzalek, like rebasing this branch every few days. We can iterate later. |
Changing new lines in those files will likely break tests that check against their output, not expecting the new line at the end. As long as the files were untouched now, I think those changes can be done separately if necessary. I'm 👍 on moving, this will avoid a lot of possible headache in future work as you guys have described. |
No problems with new lines |
👍 please don't care about new lines |
Well, I think these files should not be removed |
Ok, tests are green, so I'm merging :D |
@rafaelfranca ah, good catch! |
good catch @rafaelfranca, files with |
Sorry for the spam with new lines. ^^ 2013/6/20 Guillermo Iguaran notifications@github.com
|
Now if somebody by mistake will remove malformed files test will raise error.
I've restored files and added 🚢 |
@@ -376,6 +376,7 @@ def test_render_knows_about_types_registered_when_extensions_are_checked_earlier | |||
def test_render_ignores_templates_with_malformed_template_handlers | |||
ActiveSupport::Deprecation.silence do | |||
%w(malformed malformed.erb malformed.html.erb malformed.en.html.erb).each do |name| | |||
assert File.exists?(File.expand_path("#{FIXTURE_LOAD_PATH}/test/malformed/#{name}~")), "Malformed file (#{name}~) which should be ignored does not exists" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
some people had tried to send PRs removing the ~
files, I think this makes clear that the files are intentionally kept
|
TravisCI approves 😎 |
Extract ActionView to separate directory
👍 |
Hey,
This is continuation of work done by @drogus. Basically it moves ActionView outside of ActionPack to its own directory. AV still remains dependency on AP, I will be working on this in coming weeks.
However, after discussing it with @drogus, both of us agreed that it would be good to have those commits in master. (they are basically just moving files, not much changes is code itself) because:
/cc @pixeltrix @drogus @kaspth