We are now rails 4 #11095

Merged
merged 1 commit into from Jun 25, 2013

Conversation

Projects
None yet
6 participants
@vipulnsward
Member

vipulnsward commented Jun 25, 2013

We are now rails 4

@vipulnsward

This comment has been minimized.

Show comment
Hide comment
@vipulnsward

vipulnsward Jun 25, 2013

Member

cc @steveklabnik @fxn
Sorry about forgetting the [skip-ci].

Also does
https://github.com/vipulnsward/rails/blob/c66dbc1e5f9e031942b4f6fcadda2b2d1afae2d6/guides/source/_welcome.html.erb#L18 need to be changed to 3.2.x with 3.2 pointing to 3.2.13 ?

Member

vipulnsward commented Jun 25, 2013

cc @steveklabnik @fxn
Sorry about forgetting the [skip-ci].

Also does
https://github.com/vipulnsward/rails/blob/c66dbc1e5f9e031942b4f6fcadda2b2d1afae2d6/guides/source/_welcome.html.erb#L18 need to be changed to 3.2.x with 3.2 pointing to 3.2.13 ?

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 25, 2013

Member

@vipulnsward I'd point to both, 3.2.x and 2.3.x

Member

spastorino commented Jun 25, 2013

@vipulnsward I'd point to both, 3.2.x and 2.3.x

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 25, 2013

Member

Amend all that to the commit with the skip-ci please!

Member

spastorino commented Jun 25, 2013

Amend all that to the commit with the skip-ci please!

@dmathieu

This comment has been minimized.

Show comment
Hide comment
@dmathieu

dmathieu Jun 25, 2013

Contributor

Shouldn't this go to the 4-0-stable branch ?
Here, it's not going to be published until 4.1.

Contributor

dmathieu commented Jun 25, 2013

Shouldn't this go to the 4-0-stable branch ?
Here, it's not going to be published until 4.1.

@vipulnsward

This comment has been minimized.

Show comment
Hide comment
@vipulnsward

vipulnsward Jun 25, 2013

Member

@spastorino updated.

Member

vipulnsward commented Jun 25, 2013

@spastorino updated.

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 25, 2013

Member

oh yeah @dmathieu is right, please provide the PR for 4-0-stable

Member

spastorino commented Jun 25, 2013

oh yeah @dmathieu is right, please provide the PR for 4-0-stable

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Jun 25, 2013

Member

👍

👍

fxn added a commit that referenced this pull request Jun 25, 2013

@fxn fxn merged commit da8cb2a into rails:master Jun 25, 2013

fxn added a commit that referenced this pull request Jun 25, 2013

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 26, 2013

Member

@fxn this should be merged on 4-0-stable

Member

spastorino commented Jun 26, 2013

@fxn this should be merged on 4-0-stable

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Jun 26, 2013

Member

I backported in 52f62fe.

I backported in 52f62fe.

@fxn

This comment has been minimized.

Show comment
Hide comment
@fxn

fxn Jun 26, 2013

Member

👍

Member

fxn commented Jun 26, 2013

👍

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Jun 26, 2013

Member

@dmathieu all pull requests should be opened against master, and the person who merges will backport appropriately.

Member

steveklabnik commented Jun 26, 2013

@dmathieu all pull requests should be opened against master, and the person who merges will backport appropriately.

@spastorino

This comment has been minimized.

Show comment
Hide comment
@spastorino

spastorino Jun 27, 2013

Member

@steveklabnik agree with you but this is kind of a special case because what we should add to master is different given master is 4.1

Member

spastorino commented Jun 27, 2013

@steveklabnik agree with you but this is kind of a special case because what we should add to master is different given master is 4.1

@vipulnsward vipulnsward deleted the vipulnsward:rails_4_docs branch Feb 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment