Skip to content

We are now rails 4 #11095

Merged
merged 1 commit into from Jun 25, 2013

6 participants

@vipulnsward
Ruby on Rails member

We are now rails 4

@vipulnsward
Ruby on Rails member

cc @steveklabnik @fxn
Sorry about forgetting the [skip-ci].

Also does
https://github.com/vipulnsward/rails/blob/c66dbc1e5f9e031942b4f6fcadda2b2d1afae2d6/guides/source/_welcome.html.erb#L18 need to be changed to 3.2.x with 3.2 pointing to 3.2.13 ?

@spastorino
Ruby on Rails member

@vipulnsward I'd point to both, 3.2.x and 2.3.x

@spastorino
Ruby on Rails member

Amend all that to the commit with the skip-ci please!

@dmathieu

Shouldn't this go to the 4-0-stable branch ?
Here, it's not going to be published until 4.1.

@vipulnsward
Ruby on Rails member

@spastorino updated.

@spastorino
Ruby on Rails member

oh yeah @dmathieu is right, please provide the PR for 4-0-stable

@carlosantoniodasilva
Ruby on Rails member

:+1:

@fxn fxn merged commit da8cb2a into rails:master Jun 25, 2013
@spastorino
Ruby on Rails member

@fxn this should be merged on 4-0-stable

@carlosantoniodasilva
Ruby on Rails member

I backported in 52f62fe.

@fxn
Ruby on Rails member
fxn commented Jun 26, 2013

:+1:

@steveklabnik
Ruby on Rails member

@dmathieu all pull requests should be opened against master, and the person who merges will backport appropriately.

@spastorino
Ruby on Rails member

@steveklabnik agree with you but this is kind of a special case because what we should add to master is different given master is 4.1

@vipulnsward vipulnsward deleted the vipulnsward:rails_4_docs branch Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.