Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

removed unnecessary mapping for on options #11096

Merged
merged 1 commit into from Jun 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

melekes commented Jun 25, 2013

Right before that in assert_valid_transaction_action method we make
sure that options[:on] contains values from ACTIONS array
([:create, :destroy, :update]) and nothing more (i.e. it could not
contain strings or something else, otherwise the error is raised).

Also I've polished some docs.

@melekes melekes removed unnecessary mapping for on options
Right before that in `assert_valid_transaction_action` method we make
sure that `options[:on]` contains values from `ACTIONS` array
(`[:create, :destroy, :update]`) and nothing more (i.e. it could not
contain strings or something else, otherwise the error is raised).

Also I've polished some docs.
512f03e

@carlosantoniodasilva carlosantoniodasilva added a commit that referenced this pull request Jun 25, 2013

@carlosantoniodasilva carlosantoniodasilva Merge pull request #11096 from akalyaev/remove-unnecessary-mapping
removed unnecessary mapping for on options
7451bfc

@carlosantoniodasilva carlosantoniodasilva merged commit 7451bfc into rails:master Jun 25, 2013

@carlosantoniodasilva carlosantoniodasilva added a commit that referenced this pull request Jun 25, 2013

@carlosantoniodasilva carlosantoniodasilva Merge pull request #11096 from akalyaev/remove-unnecessary-mapping
removed unnecessary mapping for on options
2f7e087

@melekes melekes deleted the melekes:remove-unnecessary-mapping branch Jun 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment