Fetch value(s) from stringified options in tags that stringify options, based of 4-0-stable. #11178

Merged
merged 1 commit into from Jun 29, 2013

Conversation

Projects
None yet
2 participants
Contributor

JonRowe commented Jun 29, 2013

The ColorField DateTimeField and DateField tags all stringify their option keys before applying their own defaults but they attempt to use the original non-stringified @options to pick values, thus potentially overriding or missing user provided values (if you provide symbols etc)

This is #11156 targetted off 4-0-stable

Owner

rafaelfranca commented Jun 29, 2013

Changelog entry please

Contributor

JonRowe commented Jun 29, 2013

Sure, there wasn't a changelog file so I just restored it with just my entry, is that correct?

Owner

rafaelfranca commented Jun 29, 2013

On 4-0-stable it should be in the actionpack CHANGELOG

@JonRowe JonRowe fetch value(s) from stringified options
Conflicts:
	actionview/CHANGELOG.md
da38312
Contributor

JonRowe commented Jun 29, 2013

Corrected :)

@rafaelfranca rafaelfranca added a commit that referenced this pull request Jun 29, 2013

@rafaelfranca rafaelfranca Merge pull request #11178 from JonRowe/fix_tags_picking_string_keys_f…
…rom_non_stringified_options_for_4-0-stable

Fetch value(s) from stringified options in tags that stringify options, based of 4-0-stable.
35a289a

@rafaelfranca rafaelfranca merged commit 35a289a into rails:4-0-stable Jun 29, 2013

1 check was pending

default The Travis CI build is in progress
Details
Owner

rafaelfranca commented Jun 29, 2013

❤️ 💚 💙 💛 💜

JonRowe deleted the JonRowe:fix_tags_picking_string_keys_from_non_stringified_options_for_4-0-stable branch Jun 29, 2013

Contributor

JonRowe commented Jun 29, 2013

Thanks for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment