Removing not useful test related to reflect_on_all_associations #11240

Merged
merged 1 commit into from Jul 2, 2013

Projects

None yet

2 participants

@neerajdotname
Member

The comment in the test pretty much summarizes the issue.
FIXME these assertions bust a lot

Adding any type of association in class Firm will break this test.

I removed some deprecated stuff and this test failed.

I do not think this test provides any useful value. First of all who
counted last that 39 is the right number of associations.

Secondly there are a large number of tests which depend on reflection
returning right information about associations in Active Record. Those tests will start
failing if there is a bug in the code.

/cc @senny @rafaelfranca @carlosantoniodasilva

Neeraj Singh Removing not useful test related to reflect_on_all_associations
The comment in the test pretty much summarizes the issue.
`FIXME these assertions bust a lot`

Adding any type of association in class `Firm` will break this test.

I removed some deprecated stuff and this test failed.

I do not think this test provides any useful value. First of all who
counted last that 39 is the right number of associations.

Secondly there are a large number of tests which depend on reflection
returning right information about associations. Those tests will start
failing if there is a bug in the code.
1a560e6
@carlosantoniodasilva carlosantoniodasilva merged commit 173d4b9 into rails:master Jul 2, 2013

1 check passed

default The Travis CI build passed
Details
@carlosantoniodasilva

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment