3-2-stable patch: Add respond_to_missing? in TaggedLoggging #11486

Merged
merged 1 commit into from Jul 18, 2013

Conversation

Projects
None yet
5 participants
@wolframarnold
Contributor

wolframarnold commented Jul 18, 2013

Added respond_to_missing? for TaggedLogging which is needed if another log abstracter wraps a TaggedLogging instance.
Implementing respond_to_missing? is also a Ruby best practice when overriding method_missing.

Wolfram Arnold
Add respond_to_missing? for TaggedLogging which is needed if another …
…log abstracter wraps a TaggedLogging instance.

It's also best practice when overriding method_missing.
@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Jul 18, 2013

Member

Could you put the changelog entry on the top?

Member

rafaelfranca commented Jul 18, 2013

Could you put the changelog entry on the top?

rafaelfranca added a commit that referenced this pull request Jul 18, 2013

Merge pull request #11486 from wolframarnold/3-2-stable_fix_respond_t…
…o_missing_in_tagged_loggging

3-2-stable patch: Add respond_to_missing? in TaggedLoggging

@rafaelfranca rafaelfranca merged commit ed19c02 into rails:3-2-stable Jul 18, 2013

1 check failed

default The Travis CI build failed
Details

wolframarnold pushed a commit to wolframarnold/rails that referenced this pull request Jul 19, 2013

Wolfram Arnold
Update to pull request #11486:
Moved order of contibution in Changelog per Rafael's request
@UncleGene

This comment has been minimized.

Show comment
Hide comment
@UncleGene

UncleGene Aug 18, 2013

This is not compatible with 1.8.7

This is not compatible with 1.8.7

This comment has been minimized.

Show comment
Hide comment
@wolframarnold

wolframarnold Aug 19, 2013

Contributor
Contributor

wolframarnold replied Aug 19, 2013

This comment has been minimized.

Show comment
Hide comment
@pftg

pftg Aug 19, 2013

Contributor

Rails does not support 1.8.7

Contributor

pftg replied Aug 19, 2013

Rails does not support 1.8.7

This comment has been minimized.

Show comment
Hide comment
@robin850

robin850 Aug 19, 2013

Member

@pftg : Actually, this is commit in on the 3-2-stable branch.

Member

robin850 replied Aug 19, 2013

@pftg : Actually, this is commit in on the 3-2-stable branch.

This comment has been minimized.

Show comment
Hide comment
@pftg

pftg Aug 19, 2013

Contributor

oh, I see, sorry!

Contributor

pftg replied Aug 19, 2013

oh, I see, sorry!

This comment has been minimized.

Show comment
Hide comment
@robin850

robin850 Aug 19, 2013

Member

No problem! Just a FYI. 😉

Member

robin850 replied Aug 19, 2013

No problem! Just a FYI. 😉

This comment has been minimized.

Show comment
Hide comment
@UncleGene

UncleGene Aug 19, 2013

Sorry I did not update here - patch is already merged

Sorry I did not update here - patch is already merged

This comment has been minimized.

Show comment
Hide comment
@wolframarnold

wolframarnold Aug 19, 2013

Contributor
Contributor

wolframarnold replied Aug 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment