Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

The cookie jar does not to_s cookie names (keys) #1150

Merged
merged 2 commits into from May 19, 2011

Conversation

Projects
None yet
3 participants
Contributor

stevenbristol commented May 19, 2011

Because of this it is probable to have two cookies (even session cookies) in the jar, one keyed as a symbol, one as a string. These two cookies are sent to the browser and the browser "chooses" which cookie to use. If it is a session cookie (as was my case) things like csrf get reset on every request which makes submitting forms hard.

Contributor

josevalim commented May 19, 2011

Looks good, tests please?

josh added a commit that referenced this pull request May 19, 2011

Merge pull request #1150 from stevenbristol/master
The cookie jar does not to_s cookie names (keys)

@josh josh merged commit 4cf4c7f into rails:master May 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment