The cookie jar does not to_s cookie names (keys) #1150

Merged
merged 2 commits into from May 19, 2011

3 participants

@stevenbristol

Because of this it is probable to have two cookies (even session cookies) in the jar, one keyed as a symbol, one as a string. These two cookies are sent to the browser and the browser "chooses" which cookie to use. If it is a session cookie (as was my case) things like csrf get reset on every request which makes submitting forms hard.

@josevalim
Ruby on Rails member

Looks good, tests please?

@josh josh merged commit 4cf4c7f into rails:master May 19, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment