Removed command "application"#11616
Merged
carlosantoniodasilva merged 1 commit intorails:masterfrom Mar 10, 2014
Merged
Conversation
Member
Author
|
Or we could just change the description saying that it prints the rails USAGE command, But that not make sense inside a rails application. |
Member
Author
|
@rafaelfranca do you think this is valid removal ? |
Member
|
Make sense the remove IMO. 👍 @carlosantoniodasilva @guilleiguaran thoughts? |
Member
|
I'm fine, but it might be interesting to mention in the changelog at least. |
Member
Author
|
Added. Please let me know if wordings needs to change. thanks. |
railties/CHANGELOG.md
Outdated
Member
There was a problem hiding this comment.
Wrong indent. Also it might be better to say unnecessary rather than unused.
Member
Author
There was a problem hiding this comment.
@carlosantoniodasilva updated. Should be good now.
carlosantoniodasilva
added a commit
that referenced
this pull request
Mar 10, 2014
Removed command "application"
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that this command is not doing anything.
commands/application.rb is fine to have when running new inside app. But this command is not doing anything.