Removed command "application" #11616

Merged
merged 1 commit into from Mar 10, 2014

Conversation

Projects
None yet
3 participants
@arunagw
Member

arunagw commented Jul 26, 2013

I saw that this command is not doing anything.

commands/application.rb is fine to have when running new inside app. But this command is not doing anything.

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Jul 26, 2013

Member

Or we could just change the description saying that it prints the rails USAGE command,

But that not make sense inside a rails application.

Member

arunagw commented Jul 26, 2013

Or we could just change the description saying that it prints the rails USAGE command,

But that not make sense inside a rails application.

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Jul 31, 2013

Member

@rafaelfranca do you think this is valid removal ?

Member

arunagw commented Jul 31, 2013

@rafaelfranca do you think this is valid removal ?

@arthurnn

This comment has been minimized.

Show comment
Hide comment
@arthurnn

arthurnn Mar 10, 2014

Member

Make sense the remove IMO. 👍

@carlosantoniodasilva @guilleiguaran thoughts?

Member

arthurnn commented Mar 10, 2014

Make sense the remove IMO. 👍

@carlosantoniodasilva @guilleiguaran thoughts?

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Mar 10, 2014

Member

I'm fine, but it might be interesting to mention in the changelog at least.

I'm fine, but it might be interesting to mention in the changelog at least.

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Mar 10, 2014

Member

Added. Please let me know if wordings needs to change.

thanks.

Member

arunagw commented Mar 10, 2014

Added. Please let me know if wordings needs to change.

thanks.

railties/CHANGELOG.md
@@ -1,3 +1,7 @@
+* Removed unused `rails application` command.

This comment has been minimized.

@carlosantoniodasilva

carlosantoniodasilva Mar 10, 2014

Member

Wrong indent. Also it might be better to say unnecessary rather than unused.

@carlosantoniodasilva

carlosantoniodasilva Mar 10, 2014

Member

Wrong indent. Also it might be better to say unnecessary rather than unused.

This comment has been minimized.

@arunagw

arunagw Mar 10, 2014

Member

@carlosantoniodasilva updated. Should be good now.

@arunagw

arunagw Mar 10, 2014

Member

@carlosantoniodasilva updated. Should be good now.

carlosantoniodasilva added a commit that referenced this pull request Mar 10, 2014

@carlosantoniodasilva carlosantoniodasilva merged commit 80b27c2 into rails:master Mar 10, 2014

1 check was pending

default The Travis CI build is in progress
Details
@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment