Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed command "application" #11616

Merged

Conversation

@arunagw
Copy link
Member

@arunagw arunagw commented Jul 26, 2013

I saw that this command is not doing anything.

commands/application.rb is fine to have when running new inside app. But this command is not doing anything.

@arunagw
Copy link
Member Author

@arunagw arunagw commented Jul 26, 2013

Or we could just change the description saying that it prints the rails USAGE command,

But that not make sense inside a rails application.

@arunagw
Copy link
Member Author

@arunagw arunagw commented Jul 31, 2013

@rafaelfranca do you think this is valid removal ?

@arthurnn
Copy link
Member

@arthurnn arthurnn commented Mar 10, 2014

Make sense the remove IMO. 👍

@carlosantoniodasilva @guilleiguaran thoughts?

@carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Mar 10, 2014

I'm fine, but it might be interesting to mention in the changelog at least.

@arunagw
Copy link
Member Author

@arunagw arunagw commented Mar 10, 2014

Added. Please let me know if wordings needs to change.

thanks.

@carlosantoniodasilva
carlosantoniodasilva reviewed Mar 10, 2014
View changes
railties/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
* Removed unused `rails application` command.

This comment has been minimized.

@carlosantoniodasilva

carlosantoniodasilva Mar 10, 2014
Member

Wrong indent. Also it might be better to say unnecessary rather than unused.

This comment has been minimized.

@arunagw

arunagw Mar 10, 2014
Author Member

@carlosantoniodasilva updated. Should be good now.

carlosantoniodasilva added a commit that referenced this pull request Mar 10, 2014
Removed command "application"
@carlosantoniodasilva carlosantoniodasilva merged commit 80b27c2 into rails:master Mar 10, 2014
1 check was pending
1 check was pending
default The Travis CI build is in progress
Details
@carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Mar 10, 2014

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.