Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include web-console in new projects Gemfile #11667

Merged
merged 1 commit into from Sep 24, 2013

Conversation

@gsamokovarov
Copy link
Contributor

gsamokovarov commented Jul 30, 2013

As part of the Google Summer of Code 2013, me and @guilleiguaran has been working on bringing rails console to the browser. Today we are proud to announce that we hit 0.1.0 and we have enough of it, to let you guys test it.

The project development lives in https://github.com/gsamokovarov/web-console and we'll be happy to get any feedback about how we can make it better. That this is more of a demo release and we will really appreciate all of the extra testing we can get. Feel free to open issues on https://github.com/gsamokovarov/web-console/issues with any bugs, feature requests or general feedback.

/cc @guilleiguaran, @rafaelfranca, @pixeltrix, @spastorino, @drogus

@dmathieu
Copy link
Contributor

dmathieu commented Jul 30, 2013

As this is a demo, I don't think it should be included into the default Gemfile for now.

@gsamokovarov
Copy link
Contributor Author

gsamokovarov commented Jul 30, 2013

I'm opening the PR just to keep track of the integration of it into core Rails and how we should proceed with that. So yeah, we shouldn't merge at 0.1.0, but it will help with the discussion about it.

@dmathieu
Copy link
Contributor

dmathieu commented Jul 30, 2013

I understand. Unfortunately, issues aren't for discussion, but bug report.
Any feature discussion should happen in the google group.

@dmathieu
Copy link
Contributor

dmathieu commented Jul 30, 2013

Despite all my saying, your GSOC project looks awesome BTW. 💖

@pftg
Copy link
Contributor

pftg commented Jul 30, 2013

agree with @dmathieu (with both comments :) )

@ghost ghost assigned guilleiguaran Jul 30, 2013
@rafaelfranca
Copy link
Member

rafaelfranca commented Jul 30, 2013

I don't see any problem to leave this PR open here since it is a GSoC project.

@steveklabnik
Copy link
Member

steveklabnik commented Jul 30, 2013

Leaving PRs open while working on features is 100% legit.

@vipulnsward
Copy link
Member

vipulnsward commented Jul 30, 2013

👍
@gsamokovarov could you mention any milestones or work needed on rails-end if any.

@egilburg
Copy link
Contributor

egilburg commented Jul 30, 2013

+1 to open PR, but I'd prefix it with [wip] to indicate it's not ready for merge yet.

@gsamokovarov
Copy link
Contributor Author

gsamokovarov commented Jul 31, 2013

@vipulnsward I don't think that I need anything from rails, as of now. I have a couple of ideas that would make the integration a bit easier, from my perspective and I'll present those in separate PRs.

@gsamokovarov
Copy link
Contributor Author

gsamokovarov commented Jul 31, 2013

By the way, guys, if you are into Pry, we just released an adapter for it. Its a separate package, so we aren't introducing a dependency to Pry. It's an opt-in thing.

@miry
Copy link

miry commented Aug 1, 2013

@spastorino
Copy link
Member

spastorino commented Aug 19, 2013

@guilleiguaran
Copy link
Member

guilleiguaran commented Aug 19, 2013

@spastorino Thanks for your review!!! The support for Rails 3 was extracted to web-console-rails3, so I think is fine remove related code in project.

@gsamokovarov
Copy link
Contributor Author

gsamokovarov commented Aug 19, 2013

Hey @spastorino, thanks for the review! As @guilleiguaran pointed out, we did this for Rails 3 support, as there were some people that requested it. We decided to keep the code in one place and backport it on releases for the web-console-rails3 gem, which explicitly depends on Rails 3.2.

We did this, since the backport process would be easier for us, that way, but it is a fair point for you to argue that it can live in the web-console-rails3 gem. If you think that this is the better place for the code, we can move it there.

@spastorino
Copy link
Member

spastorino commented Aug 19, 2013

cool guys 👍

@guilleiguaran
Copy link
Member

guilleiguaran commented Sep 13, 2013

@spastorino we will be releasing 1.0.0 soon, do you want to do a final review? 😄

@gsamokovarov
Copy link
Contributor Author

gsamokovarov commented Sep 13, 2013

As @guilleiguaran said, we're coming to a point, where we are happy with the current feature-set and we haven't discovered any major show stoppers, so we'll release 1.0.0 early next week.

If you guys want to help out with a review, we'll greatly appreciate it!

Now its also a good time to decide whether we should link to the project in the new rails project's Gemfile. Right now I have it commented in there, as I think it's an unobtrusive way to introduce the project, should someone find it useful. If you think that we should leave it off the Gemfile or mention it in the documentation, or something along those lines, we can do that too.

@spastorino
Copy link
Member

spastorino commented Sep 21, 2013

guilleiguaran added a commit that referenced this pull request Sep 24, 2013
Include web-console in new projects Gemfile
@guilleiguaran guilleiguaran merged commit f55e178 into rails:master Sep 24, 2013
@gsamokovarov
Copy link
Contributor Author

gsamokovarov commented Sep 24, 2013

❤️ 💛 💚 💜 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.