-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include web-console in new projects Gemfile #11667
Include web-console in new projects Gemfile #11667
Conversation
As this is a demo, I don't think it should be included into the default Gemfile for now. |
I'm opening the PR just to keep track of the integration of it into core Rails and how we should proceed with that. So yeah, we shouldn't merge at |
I understand. Unfortunately, issues aren't for discussion, but bug report. |
Despite all my saying, your GSOC project looks awesome BTW. 💖 |
agree with @dmathieu (with both comments :) ) |
I don't see any problem to leave this PR open here since it is a GSoC project. |
Leaving PRs open while working on features is 100% legit. |
👍 |
+1 to open PR, but I'd prefix it with [wip] to indicate it's not ready for merge yet. |
@vipulnsward I don't think that I need anything from rails, as of now. I have a couple of ideas that would make the integration a bit easier, from my perspective and I'll present those in separate PRs. |
By the way, guys, if you are into |
@gsamokovarov may be better to create topic in https://groups.google.com/forum/#!forum/rubyonrails-talk or https://groups.google.com/forum/#!forum/rubyonrails-core for such notifications. |
why this https://github.com/gsamokovarov/web-console/blob/master/lib/web_console.rb#L15-21 ? |
How do you plan to use https://github.com/gsamokovarov/web-console/blob/master/lib/web_console.rb#L12 ? |
Also this https://github.com/gsamokovarov/web-console/blob/master/lib/web_console/backport/active_model.rb I guess is not needed |
@spastorino Thanks for your review!!! The support for Rails 3 was extracted to web-console-rails3, so I think is fine remove related code in project. |
Hey @spastorino, thanks for the review! As @guilleiguaran pointed out, we did this for Rails 3 support, as there were some people that requested it. We decided to keep the code in one place and backport it on releases for the web-console-rails3 gem, which explicitly depends on Rails 3.2. We did this, since the backport process would be easier for us, that way, but it is a fair point for you to argue that it can live in the web-console-rails3 gem. If you think that this is the better place for the code, we can move it there. |
cool guys 👍 |
@spastorino we will be releasing 1.0.0 soon, do you want to do a final review? 😄 |
As @guilleiguaran said, we're coming to a point, where we are happy with the current feature-set and we haven't discovered any major show stoppers, so we'll release 1.0.0 early next week. If you guys want to help out with a review, we'll greatly appreciate it! Now its also a good time to decide whether we should link to the project in the new rails project's Gemfile. Right now I have it commented in there, as I think it's an unobtrusive way to introduce the project, should someone find it useful. If you think that we should leave it off the Gemfile or mention it in the documentation, or something along those lines, we can do that too. |
Include web-console in new projects Gemfile
❤️ 💛 💚 💜 💙 |
As part of the Google Summer of Code 2013, me and @guilleiguaran has been working on bringing
rails console
to the browser. Today we are proud to announce that we hit0.1.0
and we have enough of it, to let you guys test it.The project development lives in https://github.com/gsamokovarov/web-console and we'll be happy to get any feedback about how we can make it better. That this is more of a demo release and we will really appreciate all of the extra testing we can get. Feel free to open issues on https://github.com/gsamokovarov/web-console/issues with any bugs, feature requests or general feedback.
/cc @guilleiguaran, @rafaelfranca, @pixeltrix, @spastorino, @drogus