Fix ActiveSupport::Testing::Isolation on jruby #11712

Merged
merged 1 commit into from Aug 2, 2013

Conversation

Projects
None yet
3 participants
Contributor

atambo commented Aug 2, 2013

Hopefully the first of many related to #11700.

With these changes the railties tests wont 100% pass but at least they
will run and show the errors.

The first problem was the @method_name variable was never set.
This was causing ENV["ISOLATION_TEST"] to always be nil which
would cause the test output to never be written to the tempfile.

The second problem was that an invalid -t option was being passed
to minitest and minitest was erroring out.

The third problem was the run method needs to always return an
instance of the test class it is trying to isolate. We were returning
a ProxyTestResult instead.

cc: @steveklabnik @arunagw

@atambo atambo Fix ActiveSupport::Testing::Isolation on jruby
Hopefully the first of many related to #11700.

With these changes the railties tests wont 100% pass but at least they
will run and show the errors.

The first problem was the @method_name variable was never set.
This was causing ENV["ISOLATION_TEST"] to always be nil which
would cause the test output to never be written to the tempfile.

The second problem was that an invalid -t option was being passed
to minitest and minitest was erroring out.

The third problem was the run method needs to always return an
instance of the test class it is trying to isolate. We were returning
a ProxyTestResult instead.
560541f
Member

arunagw commented Aug 2, 2013

Looks fine to me.

thanks 😄

rafaelfranca was assigned Aug 2, 2013

@rafaelfranca rafaelfranca added a commit that referenced this pull request Aug 2, 2013

@rafaelfranca rafaelfranca Merge pull request #11712 from atambo/activesupport_testing_isolation…
…_jruby

Fix ActiveSupport::Testing::Isolation on jruby
fd20f2e

@rafaelfranca rafaelfranca merged commit fd20f2e into rails:master Aug 2, 2013

1 check passed

default The Travis CI build passed
Details

@rafaelfranca rafaelfranca added a commit that referenced this pull request Aug 3, 2013

@rafaelfranca rafaelfranca Merge pull request #11712 from atambo/activesupport_testing_isolation…
…_jruby

Fix ActiveSupport::Testing::Isolation on jruby
ff20910

@rafaelfranca rafaelfranca added a commit that referenced this pull request Aug 3, 2013

@rafaelfranca rafaelfranca Revert "Merge pull request #11712 from atambo/activesupport_testing_i…
…solation_jruby"

This reverts commit ff20910.

Needs more work on 4-0-stable to make these tests work with JRuby
75d41df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment