Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove extra case. #11827

merged 1 commit into from Aug 26, 2013


None yet
3 participants

vipulnsward commented Aug 10, 2013

Remove extra case.

@vipulnsward Can you provide some background on why this is being removed?

This will cause a binary column to get passed to "'#{quote_string(value)}'" which will have a different outcome.

@spastorino spastorino added a commit that referenced this pull request Aug 26, 2013

@spastorino spastorino Merge pull request #11827 from vipulnsward/remove_extra_case
Remove extra case.

@spastorino spastorino merged commit 6c1bf46 into rails:master Aug 26, 2013

1 check passed

default The Travis CI build passed

spastorino commented Aug 26, 2013

@GeekOnCoffee you were looking at the wrong case statement. Basically the else case does the same as binary case was doing. Look

@vipulnsward vipulnsward deleted the vipulnsward:remove_extra_case branch Feb 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment