Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #columns_for_distinct of postgresql adapter #11896

Merged
merged 1 commit into from May 30, 2014

Conversation

Projects
None yet
3 participants
Contributor

nkondratyev commented Aug 15, 2013

No description provided.

Contributor

nkondratyev commented Aug 23, 2013

Order by clause has this general form:

  ORDER BY expression [ ASC | DESC | USING operator ] [ NULLS { FIRST | LAST } ] [, ...]

columns_for_distinct produce errors if we omit sorting direction specifiers (ASC|DESC) and specify NULLS LAST|FIRST.

This bug is fixed in this PR.

@rafaelfranca rafaelfranca modified the milestones: 4.0.5, 4.0.4, 4.0.6 Mar 10, 2014

@senny senny merged commit 1cb52a1 into rails:master May 30, 2014

1 check passed

default The Travis CI build passed
Details
Member

senny commented May 30, 2014

I finally got around to merging this. @nkondratyev thank you 💛

@senny senny added a commit that referenced this pull request May 30, 2014

@senny senny Merge pull request #11896 from nkondratyev/fix_pg_columns_for_distinct
Fixed #columns_for_distinct of postgresql adapter

Conflicts:
	activerecord/CHANGELOG.md
6c2b569

@senny senny added a commit that referenced this pull request May 30, 2014

@senny senny Merge pull request #11896 from nkondratyev/fix_pg_columns_for_distinct
Fixed #columns_for_distinct of postgresql adapter

Conflicts:
	activerecord/CHANGELOG.md

Conflicts:
	activerecord/CHANGELOG.md
3d5a201

@senny senny added a commit that referenced this pull request May 30, 2014

@senny senny Merge pull request #11896 from nkondratyev/fix_pg_columns_for_distinct
Fixed #columns_for_distinct of postgresql adapter

Conflicts:
	activerecord/CHANGELOG.md

Conflicts:
	activerecord/CHANGELOG.md
c17c04f

@nkondratyev nkondratyev deleted the nkondratyev:fix_pg_columns_for_distinct branch Jun 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment