Skip to content

Fix STI scopes using benolee's suggestion. Fixes #11939 #12084

Merged
merged 1 commit into from Oct 3, 2013

4 participants

@Ben-M
Ben-M commented Aug 30, 2013

Benolee's suggestion works and all the tests pass so why not use it? Fixes #11939.

@gzohari
gzohari commented Sep 9, 2013

build fail isn't related to code, something with 'memcache servers' on ruby 1.8.7

@sikachu sikachu added a commit to sikachu/rails that referenced this pull request Oct 3, 2013
@sikachu sikachu Port test from cf1904f to avoid future regression
Related issue: #11939, #12084
0a26530
@sikachu sikachu added a commit to sikachu/rails that referenced this pull request Oct 3, 2013
@sikachu sikachu Port test from cf1904f to avoid future regression
Related issue: #11939, #12084
68421f3
@tenderlove tenderlove merged commit 31c79e2 into rails:3-2-stable Oct 3, 2013

1 check passed

Details default The Travis CI build passed
@sikachu
Ruby on Rails member
sikachu commented Oct 3, 2013

Thanks for the patch. We've merged in this one, and it should go out with 3.2.15. We also port your test to prevent future regression on 4.0 and 4.1.

@Ben-M
Ben-M commented Oct 3, 2013

Excellent - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.