Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Upgrade jruby dependencies #12095

Merged
merged 1 commit into from Aug 31, 2013

Conversation

Projects
None yet
4 participants
Contributor

kassio commented Aug 31, 2013

related with Pull Request #12079.

rafaelfranca added a commit that referenced this pull request Aug 31, 2013

@rafaelfranca rafaelfranca merged commit 2b3a806 into rails:master Aug 31, 2013

1 check was pending

default The Travis CI build is in progress
Details
Contributor

kares commented Aug 31, 2013

it was probably fine to keep (AR) master pointing to (AR-JDBC) master ... currently AR-JDBC master has some initial support for Rails master while the stable 1.3.0 does not ... but if @kassio 'd like to fix jruby issues this way :) I'm all for it

Owner

rafaelfranca commented Aug 31, 2013

What bother me is downloading the ar-jdbc repository even if I'm not using jruby. But this should be probably fixed on bundler side.

Contributor

kassio commented Aug 31, 2013

I agree with @rafaelfranca, I guess it's better for whom doesn't use jruby don't download ar-jdbc repository.

@kassio kassio deleted the kassio:upgrade-jruby-gems branch Aug 31, 2013

Contributor

kares commented Sep 1, 2013

I fully respect your opinions (and actually admire all of your hard work) but you guys should consider the fact that some of the rails-core claim JRuby is officially supported ... now I know there's a minority of those who actually care about it but now anytime one of those few would like to run master tests from AR's side against AR-JDBC he will need to make Gemfile changes. it's fully your call but a bit demotivating esp. since there are other ways we can avoid downloading the AR-JDBC repo (on master) -- without db or putting it in another group or adding a if ENV['AR-JDBC']

@kares thanks for your input, we'd be happy to accept a patch that allows you guys to use rails master with ar-jdbc master to help testing it, as long as it does not force everyone to download the jdbc github repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment