Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
JSON encoder refactor #12183
Nice to have
This was referenced
Sep 13, 2013
this pull request
Nov 25, 2013
Numers are in!
Full stack benchmark: this uses Discourse's
Raw JSON benchmark: this uses the same Discourse seed data generator and calculates the time it takes to dump various data.
Seems like the patched version is faster than both 4.0.1 and current master!
I also started a draft on a document that goes into details on the expected behaviour of the various components. (I swear it's not as scary as it looks!) The current implementation might not be 100% inline with the draft yet, but we can work on it in future PRs.
I do plan to turn that into a higher-level user guide at some point.
The old encoder is extracted to here: https://github.com/vanruby/activesupport-json_encoder