Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add an option `end` to `find_in_batches` #12257
stop doesn't sound good to me. Consider this sentence -
added a commit
this pull request
Feb 10, 2015
I'd like to bring parity to the options. Either it's start/stop or begin_at/end_at. But mixing the language like now isn't great. I think it's fine to do a deprecation on start to go with begin_at/end_at. We don't want a mixed language wart sitting in the code base forever.
referenced this pull request
Feb 16, 2015
We can also use start/finish. Neither of those are keywords. And agree with the _at implication of date.