Also reset put_via_redirect and delete_via_redirect. #1236

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

ntalbott commented May 23, 2011

We ran in to an issue upgrading a Rails 2.3.10 project to Rails 3.0 due to put_via_redirect not being included in the list of methods that Runner wraps with a reset for @html_document. I also added delete_via_redirect for completeness.

Contributor

josevalim commented May 23, 2011

Tests please?

Contributor

ntalbott commented May 23, 2011

I wasn't able to find tests for this code; it may fall under the category of "tests for tests" since this is part of the integration testing infrastructure. If I've missed the tests please point me in the right direction and I'll be happy to add tests to make sure these methods are covered.

Member

sikachu commented Jul 11, 2011

You might try to add some test in actionpack/test/dispatch/integration_test.rb. Just create it and add your failing test case, so we know what you're fixing. ;)

@ntalbott Do you think you can bring this up-to-date with current master and add some tests, so we could merge? Thanks.

Contributor

ntalbott commented Mar 29, 2012

Don't have the cycles, unfortunately. Anyone else should feel free to pick it up, though. I'll close for now.

@ntalbott ntalbott closed this Mar 29, 2012

@ntalbott alright, thanks for reporting back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment