app generator not including script.aculo.us with Prototype #125

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

ches commented Dec 3, 2010

The recently added support for --javascript and --skip_javascript options checks for the wrong option when determining whether or not to copy the script.aculo.us JS files. Simple one-line patch plus tests resolves it. Lighthouse ticket coming in a jiffy :-)

Include script.aculo.us with --javascript app generator option
The support for --javascript and --skip_javascript options added in
708e094 checks for the wrong option when
determining whether or not to copy the script.aculo.us JS files.
Member

drogus commented Dec 10, 2010

+1 on this, looks good to me.

fxn pushed a commit that referenced this pull request Feb 2, 2013

dhh added a commit to dhh/rails that referenced this pull request Dec 14, 2015

Merge pull request #125 from lsylvester/handle-custom-loggers
Handle cases where logger is not a tagged logger.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment