GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
ActiveSupport::Inflector.inflections do |inflect|
=> "isps" (ok)
=> "some_isps" (ok)
=> "provider/is_ps" (should be provider/isps)
Has anyone had a chance to look at this yet? It is a simple and straight-forward fix.
Currently this issue breaks url_for in our application if we use namespaced model names with an acronym, among other problems. Ie, if the model was named Provider::ISP, the helper method would be incorrectly named provider_is_ps_url and url_for(Provider::ISP) fails with undefined methodprovider_isps_url'`
Please add tests and changelog entry
The patch already includes the test. I'll add a changelog entry.
Also please squash commits
Fix inflection of acronym directly after module
@pftg does this look ok now?
Is anyone still looking at this? Given it's a bug, albeit small, it would be nice if it could be fixed (and possibly backported too, allowing us to remove a monkey-patch 😉)
This is failing CI, can you update it and get it to pass?
The CI fail was on the master branch, if it is fixed I can rebase it.
I believe the regex in #14146 is slightly more elegant, closing in favor of that