Support for PostgreSQL citext data type.#12523
Conversation
There was a problem hiding this comment.
None of the other create table statements in this file are indented. I think that it would be best to indent them all in a separate pull request if having them indented is preferred.
There was a problem hiding this comment.
That PR will be rejected, as cosmetic changes. Better way to use code style for current changes.
There was a problem hiding this comment.
It is fine in the way it is. I already tried to change the style on this file and I don't think it is worth
|
This pull request needs a rebase |
|
Could you add a test for the schema.rb dump. I didn't saw this being tested |
|
Rebased, and test for schema.rb dump has been added |
|
@rafaelfranca do you have anything else to add here? |
|
@carlosantoniodasilva @rafaelfranca : What do you think about improving the documentation and adding a note about this feature in the "Ruby on Rails 4.1 Release Notes" guide (if this will be in 4.1) ? |
|
I'd also be interested in getting this merged. Anything I can do to help? |
|
👍 I'm sad this got missed from 4.1; I'm getting bored of the |
|
Can you rebase this from master? Thanks. @rafaelfranca mind taking a look here? ❤️ |
|
@carlosantoniodasilva Rebased |
|
@lsylvester can you push a rebased and squashed version of this PR? You can use brackets in the commit message to give credits to the authors: |
|
@senny I have rebased |
|
@lsylvester can we include |
…ylvester] citext makes it possible to use AR Hash finders for case-insensitive matching as sql UPPER/LOWER functions are not needed.
|
@senny I have added a citext_test.rb. |
Support for PostgreSQL citext data type.
|
@lsylvester thank you for your patience 💛 |
* master: (108 commits) make tests pass on Ruby 2.2 Use Sqlite3 adapter in examples use the body proxy to freeze headers just ask the response for the commit status, we do not need to ask the jar only write the jar if the response isn't committed Fix a grammatical error in the i18n guide [ci skip] use method_defined? to check whether or not a method is defined Enhance docs for update_attribute [ci-skip] Change usec to 0 on tests that compare seconds Unit test for mysql quote time usec Changelog entry for mysql56 microseconds Test microsecond on mysql 5.6 MySQL 5.6 and later supports microsecond precision in datetime. [ci skip] Add documentation for original_fullpath. Remove mocking on save, when not necessary comment why we are modifying global state. [ci skip] `change_table` supports `citext`. Follow up to #12523. Removed unnecessary command "application" register OID for PostgreSQL citex datatype [Troy Kruthoff & Lachlan Sylvester] Fixes STI when 2+ levels deep. ...
- The registering of citext is no longer required because Rails 4.2 added support for it in rails/rails#12523. - Also Rails 4.2 has locked minitest version to 5.5.1 so removed locking it to lower version in test_helper.
- The registering of citext is no longer required because Rails 4.2 added support for it in rails/rails#12523. - Also Rails 4.2 has locked minitest version to 5.5.1 so removed locking it to lower version in test_helper.
- The registering of citext is no longer required because Rails 4.2 added support for it in rails/rails#12523. - Also Rails 4.2 has locked minitest version to 5.5.1 so removed locking it to lower version in test_helper.
- The registering of citext is no longer required because Rails 4.2 added support for it in rails/rails#12523. - Also Rails 4.2 has locked minitest version to 5.5.1 so removed locking it to lower version in test_helper.
9 participants
citext makes it possible to use AR Hash finders for case-insensitive
matching as sql UPPER/LOWER functions are not needed.
This is an updated version of #9182 and #10231.
The schema.rb dumps now include citext columns and unknown OID warning that appeared in the test has been fixed by reconnecting to the database after the extension was enabled.