Allow any version of BCrypt #12635

Merged
merged 1 commit into from Oct 24, 2013

Conversation

Projects
None yet
3 participants
@mperham
Contributor

mperham commented Oct 24, 2013

The documentation and Gemfile generator already contain a suggested version restriction. It would be really really nice if Rails allowed developers to use a later version to take advantage of new features. For instance, we're on Rails 3.2.x and are locked to bcrypt ~3.0.0 so we can't use 3.1.x. 馃憥

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Oct 24, 2013

Member

This seems good to me. Just to reference this was added on 6779064.

@guilleiguaran do you remember why?

Member

rafaelfranca commented Oct 24, 2013

This seems good to me. Just to reference this was added on 6779064.

@guilleiguaran do you remember why?

@guilleiguaran

This comment has been minimized.

Show comment
Hide comment
@guilleiguaran

guilleiguaran Oct 24, 2013

Member

No, there are any specific reason, It was just for consistency with the version required previously in gemspec.

Member

guilleiguaran commented Oct 24, 2013

No, there are any specific reason, It was just for consistency with the version required previously in gemspec.

guilleiguaran added a commit that referenced this pull request Oct 24, 2013

@guilleiguaran guilleiguaran merged commit e33aaf4 into rails:4-0-stable Oct 24, 2013

@mperham mperham deleted the mperham:4-0-stable branch Oct 24, 2013

guilleiguaran added a commit that referenced this pull request Oct 24, 2013

rafaelfranca added a commit that referenced this pull request Oct 24, 2013

rafaelfranca added a commit that referenced this pull request Oct 24, 2013

Add CHANGELOG entry for #12635 [ci skip]
Conflicts:
	activerecord/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment