Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Merging Active Supports' to_param and to_query in a single core_ext #12644

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

tmacedo commented Oct 25, 2013

They had an undeclared circular dependency where Hash#to_param wouldn't
work unless the to_query extension was also loaded and to_query was
already requiring to_param.

ToParamTest#test_hash can reproduce the issue.

An alternative solution would be to create an extra class/mixin where the required shared behaviour would be defined.

@tmacedo tmacedo Merging Active Supports' to_param and to_query in a single core_ext
They had an undeclared circular dependency where Hash#to_param wouldn't
work unless the to_query extension was also loaded and to_query was
already requiring to_param.
aef974a
Owner

rafaelfranca commented Oct 25, 2013

Hmmm, make sense. @fxn @jeremy do you remember why we have these two files?

Owner

rafaelfranca commented Aug 18, 2014

Already done. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment