Make remote_ip detection properly handle private IPv6 addresses #12651

Merged
merged 1 commit into from May 1, 2014

Projects

None yet

3 participants

@cespare

Fixes #12638.

I didn't see any relevant tests to change.

@robin850
Ruby on Rails member

Thanks for your patch!

Could you please add a changelog entry ?

Also, I think that you could add a test here stubbing a request with the given IP in #12638 and asserting the expected result.

@cespare

@robin850 Done, PTAL.

@rafaelfranca rafaelfranca merged commit cd78d72 into rails:master May 1, 2014

1 check failed

Details default The Travis CI build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment