New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ActiveRecord::Relation YAML serialization, for #5303 issue #12749

Merged
merged 1 commit into from Nov 11, 2013

Conversation

Projects
None yet
3 participants
@iantropov
Copy link
Contributor

iantropov commented Nov 3, 2013

This test checks the fix of #5303 issue. It depends from PR rails/arel#216

@@ -43,4 +43,8 @@ def test_psych_roundtrip_new_object
t = Psych.load Psych.dump topic
assert_equal topic.attributes, t.attributes
end

def test_active_record_relation_serialization
[Topic.all].to_yaml

This comment has been minimized.

@melekes

melekes Nov 4, 2013

Contributor

I do not see any assertion here. Maybe we should add one:

assert_nothing_raised do
  [Topic.all].to_yaml
end

@iantropov What do you think?

This comment has been minimized.

@iantropov

iantropov Nov 4, 2013

Contributor

@akalyaev Thanks for attention!
I don`t think that it is necessary - because without patch this code will produce a error.

This comment has been minimized.

@rafaelfranca

rafaelfranca Nov 4, 2013

Member

Yes, also assert_nothing_raised is deprecated.

This comment has been minimized.

@melekes

melekes Nov 4, 2013

Contributor

Didn't know that, sorry :(

rafaelfranca added a commit that referenced this pull request Nov 11, 2013

Merge pull request #12749 from iantropov/issue_5303
Add test for ActiveRecord::Relation YAML serialization, for #5303 issue

@rafaelfranca rafaelfranca merged commit 0c89d31 into rails:master Nov 11, 2013

1 check failed

default The Travis CI build failed
Details

rafaelfranca added a commit that referenced this pull request Nov 11, 2013

Merge pull request #12749 from iantropov/issue_5303
Add test for ActiveRecord::Relation YAML serialization, for #5303 issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment