New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose internal state in the public encoder API (i.e. as_json) #12785

Merged
merged 2 commits into from Nov 7, 2013
Commits on Nov 7, 2013
  1. Do not expose internal state in the public encoder API (i.e. as_json)

    chancancode committed Nov 6, 2013
    See [1] for why this is not a good idea.
    
    As part of this refactor, circular reference protection in as_json has
    been removed and the corresponding error class has been deprecated.
    
    As discussed with @jeremy, circular reference error is considered
    programmer errors and protecting against it is out of scope for
    the encoder.
    
    This is again based on the excellent work by @sergiocampama in #11728.
    
    [1]: intridea/multi_json#138 (comment)