removed deprecated methods, and related tests, from ActionPack #1281

Merged
merged 1 commit into from May 24, 2011

Projects

None yet

2 participants

@joshk
joshk commented May 24, 2011

Hey Guys,

Please let me know if you see anything amiss.

Thanks,

Josh

@josevalim josevalim commented on an outdated diff May 24, 2011
actionpack/lib/action_controller.rb
@@ -37,11 +37,6 @@ module ActionController
autoload :UrlFor
end
- autoload :Integration, 'action_controller/deprecated/integration_test'
@josevalim
josevalim May 24, 2011 Ruby on Rails member

Those constants were never really deprecated, so they should stay.

@josevalim josevalim commented on an outdated diff May 24, 2011
actionpack/lib/action_view/template/handler.rb
@@ -6,12 +6,6 @@ module ActionView
class Template
module Handlers #:nodoc:
module Compilable
@josevalim
josevalim May 24, 2011 Ruby on Rails member

This should be changed by throwing the whole Compilable module away, not just the deprecation warning. We don't need it.

@josevalim josevalim commented on an outdated diff May 24, 2011
actionpack/lib/action_view/template/handler.rb
@@ -28,12 +22,6 @@ module ActionView
class_attribute :default_format
self.default_format = Mime::HTML
- def self.inherited(base)
@josevalim
josevalim May 24, 2011 Ruby on Rails member

This should be changed by throwing the whole Template::Handler class away, not just the deprecation warning. We don't need it.

@joshk
joshk commented May 24, 2011

@josevalim updated with your feedback, let me know if you see anything else which should be updated

@josevalim josevalim merged commit 6f413d8 into rails:master May 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment