Update security.md #12815

Merged
merged 1 commit into from Nov 11, 2013

Projects

None yet

4 participants

@mrageh

Hi Guys
I was reading through this guide last night and noticed a small mistake, would be great if you could update it.
I changed the word 'building' to 'build' in line 20.
"Web application frameworks are made to help developers building web applications"

Adam Update security.md
Hi Guys 
I was reading through this guide last night and noticed a small mistake, would be great if you could update it. 
I changed the word 'building' to 'build' in line 20. 
"Web application frameworks are made to help developers building web applications"
336caf9
@rafaelfranca
Ruby on Rails member

I think both are correct. @fxn could you take a look?

@mrageh

ok try and read the original sentence without taking a breath. It would make a lot of sense, when you stop briefly
after the word 'developers'. Adding a comma after 'developers' would make it a lot clearer and I can do that if you allow
me to.
:)

@fearofcode

Both of them could be interpreted in a way that's grammatically valid (they help developers build web applications vs they help developers perpetually working on web applications), but using the infinitive form "build" seems clearer.

@mrageh

Yeah I have to agree you are right, should I leave the commit and close this issue?

@rafaelfranca
Ruby on Rails member

Lets wait @fxn

@fxn fxn was assigned Nov 9, 2013
@mrageh

Should we still wait rafael?

@fxn
Ruby on Rails member

Sorry, I'll have a look tonight!

@fxn
Ruby on Rails member

Ah, the patch is trivial, looks good to me.

@fxn fxn merged commit b31b6e6 into rails:master Nov 11, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment