-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Spring preloader when generating new applications #12958
Conversation
Huge |
Coooool! ⛵ Changelog entry missing 😉 |
Note to self: I think we need to skip spring if the generating platform doesn't support |
👍 |
1 similar comment
👍 |
One thing I'm thinking about. Spring should probably only be a development environment concern. I don't think you want spring running on a deployed server running in non-dev mode. How can we deal with that for the stubs? |
It's already handled by the fact that spring is in the development group of the gemfile. So it's not installed on the server. If it's not installed, the binstub just bypasses spring and runs the underlying command. |
Perfect then! On Nov 20, 2013, at 10:30 AM, Jon Leighton notifications@github.com wrote:
|
Fixed test failures and disabled installation of spring if the generating platform does not support Process.fork. |
@@ -1,3 +1,9 @@ | |||
* The [Spring application | |||
preloader](https://github.com/jonleighton/spring) is now installed | |||
by default for new applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention it's development only? (wondering about people reading this and thinking "ZOMG App Preloader").
Happy to have spring in the default set of tools 👍 |
👍 |
Please rebase this and !!! |
Yep, I will. Need to fix some tests too. I am slow :) |
Install Spring preloader when generating new applications
We have discussed among the core team about installing spring in newly generated applications by default. Here's my proposed integration.