Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Spring preloader when generating new applications #12958

Merged
merged 1 commit into from Dec 4, 2013

Conversation

@jonleighton
Copy link
Member

jonleighton commented Nov 19, 2013

We have discussed among the core team about installing spring in newly generated applications by default. Here's my proposed integration.

@rafaelfranca
Copy link
Member

rafaelfranca commented Nov 19, 2013

Huge :shipit:

@lukaszx0
Copy link
Member

lukaszx0 commented Nov 20, 2013

Coooool!

Changelog entry missing 😉

@jonleighton
Copy link
Member Author

jonleighton commented Nov 20, 2013

Note to self: I think we need to skip spring if the generating platform doesn't support Process.fork.

@pftg
Copy link
Contributor

pftg commented Nov 20, 2013

👍

1 similar comment
@vipulnsward
Copy link
Member

vipulnsward commented Nov 20, 2013

👍

@dhh
Copy link
Member

dhh commented Nov 20, 2013

One thing I'm thinking about. Spring should probably only be a development environment concern. I don't think you want spring running on a deployed server running in non-dev mode. How can we deal with that for the stubs?

@jonleighton
Copy link
Member Author

jonleighton commented Nov 20, 2013

It's already handled by the fact that spring is in the development group of the gemfile. So it's not installed on the server. If it's not installed, the binstub just bypasses spring and runs the underlying command.

@dhh
Copy link
Member

dhh commented Nov 20, 2013

Perfect then!

On Nov 20, 2013, at 10:30 AM, Jon Leighton notifications@github.com wrote:

It's already handle by the fact that spring is in the development group of the gemfile. So it's not installed on the server. If it's not installed, the binstub just bypasses spring and runs the underlying command.


Reply to this email directly or view it on GitHub.

@jonleighton
Copy link
Member Author

jonleighton commented Nov 20, 2013

Fixed test failures and disabled installation of spring if the generating platform does not support Process.fork.

@carlosantoniodasilva
carlosantoniodasilva reviewed Nov 22, 2013
View changes
railties/CHANGELOG.md Outdated
@@ -1,3 +1,9 @@
* The [Spring application
preloader](https://github.com/jonleighton/spring) is now installed
by default for new applications.

This comment has been minimized.

Copy link
@carlosantoniodasilva

carlosantoniodasilva Nov 22, 2013

Member

Should we mention it's development only? (wondering about people reading this and thinking "ZOMG App Preloader").

@carlosantoniodasilva
Copy link
Member

carlosantoniodasilva commented Nov 22, 2013

Happy to have spring in the default set of tools 👍

@exAspArk
Copy link
Contributor

exAspArk commented Nov 28, 2013

👍

@guilleiguaran
Copy link
Member

guilleiguaran commented Dec 1, 2013

Please rebase this and :shipit: !!!

@jonleighton
Copy link
Member Author

jonleighton commented Dec 1, 2013

Yep, I will. Need to fix some tests too. I am slow :)

jonleighton added a commit that referenced this pull request Dec 4, 2013
Install Spring preloader when generating new applications
@jonleighton jonleighton merged commit 6f72a6b into rails:master Dec 4, 2013
1 check failed
1 check failed
default The Travis CI build failed
Details
senny added a commit that referenced this pull request Dec 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.