Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Resubmitting issue #636 as a pull request #1296

Merged
merged 1 commit into from Jul 11, 2011

Conversation

Projects
None yet
3 participants
Contributor

kaiwren commented May 25, 2011

See #636

Member

sikachu commented Jul 11, 2011

The patch looks good. But I rather have the wording of the commit to mention what it tries to fix instead. Do you mind amending your commit and force push to your branch?

Thank you.

/cc @josevalim

Contributor

kaiwren commented Jul 11, 2011

Done. Thank you.

josevalim added a commit that referenced this pull request Jul 11, 2011

Merge pull request #1296 from c42engineering/issue636
Resubmitting issue #636 as a pull request

@josevalim josevalim merged commit e9f9ce9 into rails:master Jul 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment