allow a limit for delete_all, and use joins natively for mysql and postgres for update and delete #13301

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

ccutrer commented Dec 12, 2013

all require rails/arel#228

@chancancode chancancode commented on the diff Dec 13, 2013

@@ -12,6 +12,7 @@ gem 'bcrypt-ruby', '~> 3.1.2'
gem 'jquery-rails', '~> 2.2.0'
gem 'turbolinks'
gem 'coffee-rails', '~> 4.0.0'
+gem 'arel', github: 'rails/arel', branch: 'master'
@chancancode

chancancode Dec 13, 2013

Owner

Please remove this

@ccutrer

ccutrer Dec 13, 2013

Contributor

should I instead wait for a new version of the arel gem, and update the gemspec to require that version?

@chancancode

chancancode Dec 13, 2013

Owner

Hi @ccutrer, Rails master already depends on arel 5.0.0 (https://github.com/rails/rails/blob/master/activerecord/activerecord.gemspec#L27). Does this depend on arel features that's added after the 5.0.0 release?

@ccutrer

ccutrer Dec 13, 2013

Contributor

Yes, it depends on this pull request: rails/arel#228

@chancancode

chancancode Dec 13, 2013

Owner

In that case, putting this here won't actually help either, I'm pretty sure we can't do anything about this until there's a decision on the related PR in arel, but I'll defer to core team members to help you sort this out 👍

sgrif was assigned by rails-bot Oct 20, 2015

Member

maclover7 commented Jan 10, 2016

Please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment