New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Integration of mail_view gem #13332

Merged
merged 3 commits into from Dec 17, 2013

Conversation

Projects
None yet
10 participants
@pixeltrix
Copy link
Member

pixeltrix commented Dec 16, 2013

I know this needs more tests and documentation - they are coming but I'd like to get some feedback on the implementation whilst I finish off those today.

/cc @dhh

@vipulnsward

This comment has been minimized.

Copy link
Member

vipulnsward commented Dec 16, 2013

💯

@vipulnsward

View changes

actionmailer/lib/action_mailer/base.rb Outdated
# end
#
# Methods must return a Mail object which can be generated by calling the mailer method
# without the additional <tt>deliver</tt>. The location of the mailer previews directory

This comment has been minimized.

@vipulnsward

vipulnsward Dec 16, 2013

Member

should preview suppress deliver even if called accidentally?

This comment has been minimized.

@pixeltrix

pixeltrix Dec 16, 2013

Member

Possibly, but I'm not sure how you'd do it - wrap the call method in a block that disables deliveries I guess.

This comment has been minimized.

@dhh

dhh Dec 16, 2013

Member

I don't think that's necessary. The documentation spells that out clearly, and anyone who forgets by mistake will see the error right away. I'd rather fail loud and early than try to pave over it.

@carlosantoniodasilva

This comment has been minimized.

Copy link
Member

carlosantoniodasilva commented Dec 16, 2013

👍

@mbhnyc

This comment has been minimized.

Copy link
Contributor

mbhnyc commented Dec 16, 2013

oh my gosh. this makes me so happy! 👍

@dhh

This comment has been minimized.

Copy link
Member

dhh commented Dec 16, 2013

Great stuff! 👍

@soundarapandian

This comment has been minimized.

Copy link

soundarapandian commented Dec 16, 2013

Awesome feature 👍

# end
# end
#
# Methods must return a Mail object which can be generated by calling the mailer method

This comment has been minimized.

@chancancode

chancancode Dec 16, 2013

Member

Should this be return a <tt>Mail::Message</tt> object? (From here)

This comment has been minimized.

@pixeltrix

pixeltrix Dec 17, 2013

Member

Probably - I was going off the mail_view gem documentation 😄

guilleiguaran added a commit that referenced this pull request Dec 17, 2013

Merge pull request #13332 from rails/pixeltrix/mail_view
WIP: Integration of mail_view gem

@guilleiguaran guilleiguaran merged commit 666d945 into master Dec 17, 2013

1 check was pending

default The Travis CI build is in progress
Details
@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Dec 17, 2013

@guilleiguaran should we had merged this? It was marked as WIP

@guilleiguaran

This comment has been minimized.

Copy link
Member

guilleiguaran commented Dec 17, 2013

@rafaelfranca yes!!!, @pixeltrix confirmed that this was ready for merge if tests were green in Travis 😄

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Dec 17, 2013

❤️. deleting the branch.

@rafaelfranca rafaelfranca deleted the pixeltrix/mail_view branch Dec 17, 2013

@hristopeev

This comment has been minimized.

Copy link

hristopeev commented Dec 11, 2014

Hello,
Is it possible to use mail preview in production environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment