Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon. #13335

Merged
merged 1 commit into from Apr 22, 2014

Projects

None yet

4 participants

@glorieux

Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon,
registered in 2003, it was submitted to IANA by a third party and is not recognised by Microsoft products.
The MIME type image/x-icon should be used since is the one recognised by the major browsers on the market.

@sikachu
Ruby on Rails member

I'm 👍 to this change. Would you mind rebase this so we can merge it in?

@glorieux

@sikachu Now rebased.

@robin850 robin850 commented on an outdated diff Apr 21, 2014
actionview/CHANGELOG.md
@@ -1,3 +1,17 @@
+* Change favicon_link_tag default mimetype from image/vnd.microsoft.icon to image/x-icon.
@robin850
robin850 Apr 21, 2014

Could you wrap this line around 80 chars and wrap code snippets inside backticks (i.e. favicon_link_tag and image/...) please ? Thanks for your contribution! :-)

@glorieux

@robin850 Is the text formatting better now?

@robin850 robin850 commented on an outdated diff Apr 21, 2014
actionview/CHANGELOG.md
@@ -1,3 +1,18 @@
+* Change favicon_link_tag default mimetype from image/vnd.microsoft.icon to
+ image/x-icon.
+
+ Before:
+
+ `favicon_link_tag 'myicon.ico'`
@robin850
robin850 Apr 21, 2014

Actually the code samples were fine, sorry for not being crystal clear. My comment was about the first line of your entry. Something along the lines of:

*   Change `favicon_link_tag` default mime-type from `image/vnd.microsoft.icon`
    to `image/x-icon`.
@glorieux glorieux Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon…
… to image/x-icon.

Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon,
registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products.
The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
c8b7ad1
@glorieux

@robin850 Oh OK. Think it's all good now.

@rafaelfranca rafaelfranca merged commit 99613f0 into rails:master Apr 22, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@robin850
Ruby on Rails member

@glorieux : Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment