Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default I18n.enforce_available_locales to true #13341

Merged
merged 4 commits into from Dec 17, 2013

Conversation

carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Dec 16, 2013

We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option.

Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.

We will default this option to true from now on to ensure users properly
handle their list of available locales whenever necessary. This option
was added as a security measure and thus Rails will follow it defaulting
to secure option.

Also improve the handling of I18n config options in its railtie, taking
the new enforce_available_locales option into account, by setting it as
the last one in the process. This ensures no other configuration will
trigger a deprecation warning due to that setting.
The option enforce_available_locales is only available on latest
versions, so require the last available one which has the option +
other related fixes and should not have backward compatibility issues.
@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Dec 17, 2013

:shipit:

carlosantoniodasilva added a commit that referenced this issue Dec 17, 2013
Default I18n.enforce_available_locales to true

We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option.

Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.
@carlosantoniodasilva carlosantoniodasilva merged commit ae196e8 into rails:master Dec 17, 2013
1 check passed
@carlosantoniodasilva carlosantoniodasilva deleted the ca-i18n branch Dec 17, 2013
carlosantoniodasilva added a commit that referenced this issue Dec 23, 2013
Default I18n.enforce_available_locales to true

We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option.

Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.

Conflicts:
	actionview/test/abstract_unit.rb
	activesupport/CHANGELOG.md
	activesupport/activesupport.gemspec
	activesupport/lib/active_support/i18n_railtie.rb
	activesupport/test/abstract_unit.rb
	guides/source/upgrading_ruby_on_rails.md
	railties/test/application/initializers/i18n_test.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants