Remove line causing uninitialized constant Sprockets::Helpers #1341

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@lardawge
Contributor

lardawge commented May 26, 2011

As far as I can tell this is not needed. Running the task with the original
line, ActionView::Helpers::SprocketsHelper, does nothing different to the final output.
Whatever the case, I could find nowhere that Sprockets::Helpers is defined.

Other option is to revert 9701014

@josh can you shed some light on this?

Remove line causing uninitialized constant Sprockets::Helpers
As far as I can tell this is not needed. Running the task with the original
line, ActionView::Helpers::SprocketsHelper, does nothing different to the final output.
Whatever the case, I could find nowhere that Sprockets::Helpers is defined.

Other option is to revert 9701014
@lardawge

This comment has been minimized.

Show comment Hide comment
@lardawge

lardawge May 26, 2011

Contributor

Looks like this is happening because of an inconsistant state between master and 3-1-stable. Particularly actionpack/lib/sprockets/helpers which doesn't exist in 3-1-stable. Still questionable if it is actually needed.

Contributor

lardawge commented May 26, 2011

Looks like this is happening because of an inconsistant state between master and 3-1-stable. Particularly actionpack/lib/sprockets/helpers which doesn't exist in 3-1-stable. Still questionable if it is actually needed.

@lardawge

This comment has been minimized.

Show comment Hide comment
@lardawge

lardawge May 26, 2011

Contributor

This is actually only happening in rails 3-1-stable...

Contributor

lardawge commented May 26, 2011

This is actually only happening in rails 3-1-stable...

@lardawge lardawge closed this May 26, 2011

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

auto_link view helper was failing on URLs with colons after a query p…
…aram

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1341 state:committed]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment