Render select tag before hidden input #13524

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@aaronjensen
Contributor

Prior to this, if you render a select tag with the form helper you end up
with a idden field followed by the select tag. This is fine in most cases,
but on older versions of IE, when you are wrapping said select tag with a
label tag, the label will get associated with the hidden field rather
than the select so a click on the label will have no effect as opposed
to focusing on the select itself.

Fixes #13523

@aaronjensen aaronjensen Render select tag before hidden input
Prior to this, if you render a select tag with the form helper you end up
with a idden field followed by the select tag. This is fine in most cases,
but on older versions of IE, when you are wrapping said select tag with a
label tag, the label will get associated with the hidden field rather
than the select so a click on the label will have no effect as opposed
to focusing on the select itself.
3540a9c
@rafaelfranca
Member

Thank you for the pull request. As I commented in the original issue, this change will break the behavior making the wrong parameter to be submitted.

@robin850 robin850 added the actionview label May 4, 2014
@robin850 robin850 modified the milestone: 4.0.6 May 4, 2014
@robin850
Member
robin850 commented May 4, 2014

I take the liberty to reopen the discussion here as #13523 has been reopened.

@robin850 robin850 reopened this May 4, 2014
@aaronjensen
Contributor

So, what would it take to get this merged in? It's been open for a while now, it is a simple change and has tests. Anything else?

@aaronjensen
Contributor

@rafaelfranca Hi, is this ok to merge in now?

@aaronjensen
Contributor

@rafaelfranca and I discussed briefly over email, this should be ready for a merge. Please let me know if there is anything you'd like me to tweak, thanks! /cc @robin850

@matthewd matthewd closed this Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment