Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for relative_url_root when used with sprockets #1372

Merged
merged 1 commit into from May 28, 2011

Conversation

Projects
None yet
2 participants
Contributor

jacott commented May 28, 2011

Sprockets does not use the ActionView::Helpers::AssetTagHelper::AssetPaths sub-class of ActionView::Helpers::AssetPaths which is where the relative_url_root logic has been moved to.

This fix moves the relative_url_root logic into ActionView::Helpers::AssetPaths so that it works with sprockets.

@josevalim josevalim added a commit that referenced this pull request May 28, 2011

@josevalim josevalim Merge pull request #1372 from jacott/master
Fix for relative_url_root when used with sprockets
f07ff6b

@josevalim josevalim merged commit f07ff6b into rails:master May 28, 2011

@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

@defunkt @dhh defunkt + dhh Properly check silence_spec_warnings class variable [#1372 state:comm…
…itted]

Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
3341787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment