Add travel_back to remove stubs from travel and travel_to and remove auto-rollback after each test case
#13884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,8 +62,7 @@ def travel(duration, &block) | |||
| end | |||
|
|
|||
| # Change current time to the given time by stubbing +Time.now+ and +Date.today+ to return the | |||
| # time or date passed into this method. Note that the stubs are automatically removed | |||
| # at the end of each test. | |||
| # time or date passed into this method. | |||
There was a problem hiding this comment.
You'll want to keep the doc on this method intact, as we really travelling back on the block form.
There was a problem hiding this comment.
This is documented below:
# This method also accepts a block, which will return the current time back to its original
# state at the end of the block:
What I removed is the automatically removal of the stubs in the non-block version.
There was a problem hiding this comment.
Oh, ha. I read it wrong. This is good to go 👍
ghost
assigned 
| @@ -607,6 +607,9 @@ for detailed changes. | |||
| `Time.now` and | |||
| `Date.today`. ([Pull Request](https://github.com/rails/rails/pull/12824)) | |||
|
|
|||
| * Added `ActiveSupport::Testing::TimeHelpers#travel_back`. This method return | |||
|
@rafaelfranca looking good 👍 |
This behavior is only work out-of-box with minitest and also add a downside to run after each test case, even if we don't used the travel or travel_to methods
rafaelfranca
added a commit
that referenced
this pull request
Jan 30, 2014
Add `travel_back` to remove stubs from `travel` and `travel_to` and remove auto-rollback after each test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a alternative implementation of #12966.
The reason is the same plus, I'm removing the auto-rollback after each test case. The reason is this auto-rollback will only work with minitest out of the box and it may confuse the users.
Closes #12966