New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `travel_back` to remove stubs from `travel` and `travel_to` and remove auto-rollback after each test case #13884

Merged
merged 3 commits into from Jan 30, 2014

Conversation

Projects
None yet
5 participants
@rafaelfranca
Member

rafaelfranca commented Jan 30, 2014

This is a alternative implementation of #12966.

The reason is the same plus, I'm removing the auto-rollback after each test case. The reason is this auto-rollback will only work with minitest out of the box and it may confuse the users.

Closes #12966

@sikachu

View changes

Show outdated Hide outdated activesupport/lib/active_support/testing/time_helpers.rb
@sikachu

View changes

Show outdated Hide outdated activesupport/lib/active_support/testing/time_helpers.rb
@fxn

View changes

Show outdated Hide outdated guides/source/4_1_release_notes.md
@carlosantoniodasilva

View changes

Show outdated Hide outdated activesupport/lib/active_support/testing/time_helpers.rb
@senny

This comment has been minimized.

Show comment
Hide comment
@senny

senny Jan 30, 2014

Member

@rafaelfranca looking good 👍

Member

senny commented Jan 30, 2014

@rafaelfranca looking good 👍

rafaelfranca added some commits Jan 30, 2014

Remove automatic removal of Date/Time stubs after each test case
This behavior is only work out-of-box with minitest and also add a
downside to run after each test case, even if we don't used the travel
or travel_to methods

rafaelfranca added a commit that referenced this pull request Jan 30, 2014

Merge pull request #13884 from rafaelfranca/rm-travel-back
Add `travel_back` to remove stubs from `travel` and `travel_to` and remove auto-rollback after each test case

@rafaelfranca rafaelfranca merged commit db6f69f into rails:master Jan 30, 2014

@rafaelfranca rafaelfranca deleted the rafaelfranca:rm-travel-back branch Jan 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment