Add config to disable schema dump after migration #13948
Looks good. Just a couple of details.
I believe the flag should not appear in test.rb. I explained the rationale in the mailing list but the summary is that since you are not supposed to run migrations in the test environment, it looks strange that the config file says anything about them. The comment is enlightening, see "Do not dump schema after migrations", "in the test environment? which migrations? I am not supposed to run migrations in the test environment!", the user may wonder.
Since migrations do not run, the implicit true value is fine, it won't hurt.
Then some details regarding the values of the flag. We try to avoid using singletons in docs and tests. As far as the user is concerned this is a flag. We could assign anything to it that is true, and the user can set it to
@fxn , Thanks for the amazing feedback ! I've removed the config from
* Add a config on Active Record named `dump_schema_after_migration` * Schema dump doesn't happen if the config is set to false * Set default value of the config to true * Set config in generated production environment file to false * Update configuration guide * Update CHANGELOG
* Updated sample database.yml file. * Added sidekiq config file. * Removed rails_12factor gem. Added required config changes for heroku logging. * Removed tagged_logging initializer file. The tagged logging configs are handled separately for each env. * Do not dump schema after migrations. https://groups.google.com/forum/#!topic/rubyonrails-core/h4cQXmKuB7M rails/rails#13948 * Enabled force_ssl config. * Added comments about config/initializers/assets.rb. * reverting some of the changes Co-authored-by: Raj Singh <email@example.com>