context in validation goes through has many relationship #13978

Merged
merged 1 commit into from Feb 9, 2014

Conversation

Projects
None yet
2 participants
@Fortisque
Contributor

Fortisque commented Feb 8, 2014

this resolves #13854

tenderlove added a commit that referenced this pull request Feb 9, 2014

Merge pull request #13978 from Fortisque/kevin/validation_context_for…
…_children

context in validation goes through has many relationship

@tenderlove tenderlove merged commit f99b254 into rails:master Feb 9, 2014

1 check passed

default The Travis CI build passed
Details

huoxito added a commit to huoxito/spree that referenced this pull request Feb 11, 2014

Create real Order object in promotion_spec
See rails/rails#13978

It looks like it broke rspec-rails stub_model implementation when
assigning that stub to its parent. (in a has many context)

A similar case also happens with mock_model (failing with *unexpected
message attribute*)

huoxito referenced this pull request in spree/spree Mar 17, 2014

Use stub_model rathen than mock_model
Make rails 4.0.4 build happy

huoxito added a commit to spree/spree that referenced this pull request Apr 11, 2014

Create real Order object in promotion_spec
See rails/rails#13978

It looks like it broke rspec-rails stub_model implementation when
assigning that stub to its parent. (in a has many context)

A similar case also happens with mock_model (failing with *unexpected
message attribute*)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment