Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Hide bundler output for `rails new` if quiet option is specified. #14025

Merged
merged 1 commit into from Feb 12, 2014

Conversation

Projects
None yet
3 participants
Contributor

xtian commented Feb 12, 2014

I noticed that even if you run rails new with --quiet, Bundler output is still printed to the terminal.

I'm not sure how to write a unit test for this, though, since it's using backticks and actually running the Bundler command was pretty slow.

Have you tried using assert_silent for the unit test?

Member

senny commented Feb 12, 2014

@xtian Travis segfaulted. I'm rerunning the job.

Member

senny commented Feb 12, 2014

I agree that running a full bundle to verify the output would be overkill. @xtian thanks for your work 💛

@senny senny added a commit that referenced this pull request Feb 12, 2014

@senny senny Merge pull request #14025 from xtian/rails-new-quiet
Hide bundler output for `rails new` if quiet option is specified.
8cdd93a

@senny senny merged commit 8cdd93a into rails:master Feb 12, 2014

1 check passed

default The Travis CI build passed
Details

@xtian xtian deleted the unknown repository branch Feb 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment