Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rename update_record / create_record methods #14027

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

This change renames the update_record and create_record methods in back to update and create to avoid conflicts with dynamically generated create_#{association_name}/update_#{association_name} methods for associations.

Check issue #11645.

Member

vipulnsward commented Feb 12, 2014

@davidpiegza This breaks the build, I don't think update/create would work.
https://travis-ci.org/rails/rails/jobs/18731329

Member

senny commented Feb 12, 2014

If those are #nodoced methods, we should prefix them with an _ to prevent further naming conflicts.

@senny senny added the activerecord label Feb 12, 2014

We can't use update because that's now a public method for AR objects, that's why these internal methods have been renamed. I think there was another pull request to change this, not sure.

Ok, sorry, I forgot about the other PR.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment