Dont use Enumarator on join_association #14045

Merged
merged 1 commit into from Feb 13, 2014

Conversation

Projects
None yet
4 participants
Member

arthurnn commented Feb 13, 2014

Fibers are evil .. AR should avoid them when possible.

Didnt full branchmark this, but just running the tests we can see a difference:
time bundle exec rake test_sqlite3

Without the patch:
real0m41.930s
user0m32.107s
sys0m2.815s
With the patch:
real0m41.203s
user0m31.371s
sys0m2.772s

review @rafaelfranca @tenderlove

@arthurnn arthurnn Dont use Enumarator on join_association c387252

@robin850 robin850 modified the milestone: 4.0.3 Feb 13, 2014

@guilleiguaran guilleiguaran added a commit that referenced this pull request Feb 13, 2014

@guilleiguaran guilleiguaran Merge pull request #14045 from arthurnn/kill_fibers
Dont use Enumarator on join_association
24fc74c

@guilleiguaran guilleiguaran merged commit 24fc74c into rails:master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details

arthurnn deleted the arthurnn:kill_fibers branch Feb 13, 2014

Owner

rafaelfranca commented Feb 14, 2014

I think this is supposed to be backported right?

Member

arthurnn commented Feb 14, 2014

@rafaelfranca actually that only existed on master. So no need to backport

Owner

rafaelfranca commented Feb 14, 2014

👍 Thanks

robin850 removed this from the 4.0.3 milestone Feb 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment