Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SQLite3Adapter now checks for views in table_exists? fixes: 14041 #14056

Merged
merged 1 commit into from Sep 9, 2014

Conversation

Projects
None yet
3 participants
Contributor

girishso commented Feb 14, 2014

Added check for database views in table_exists? in SQLite3Adapter

Fixes #14041

Contributor

dmathieu commented Feb 14, 2014

I'm afraid there are a lot of unexpected repercussions here.
What if the view is readonly for example?
Also, what about other database adapters? MySQL takes only tables.

Contributor

girishso commented Feb 14, 2014

@dmathieu MySQL show tables; by default includes the views.
Also, as mentioned in #14041 (comment) the same is true for Postgres.

@senny senny added the activerecord label Sep 9, 2014

@senny senny self-assigned this Sep 9, 2014

@senny senny merged commit bbf6df7 into rails:master Sep 9, 2014

1 check passed

default The Travis CI build passed
Details
Member

senny commented Sep 9, 2014

While writing these tests it became obvious that the SQLite3Adapter is behaving different from the other adapters.

@girishso thank you 💛

@senny senny added a commit that referenced this pull request Sep 9, 2014

@senny senny Merge pull request #14056 from girishso/14041
SQLite3Adapter now checks for views in table_exists? fixes: 14041

Conflicts:
	activerecord/CHANGELOG.md
d2069d6
Contributor

girishso commented Sep 9, 2014

Woohoo my first rails commit!! :)

Thanks @senny! wondering how you found this 7 month old pull request!

Member

senny commented Sep 9, 2014

@girishso working through my todo-list. Sadly there's still stuff on it that's 7 months old. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment