Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

re-raise error if error occurs before committing in streaming #14090

Merged
merged 1 commit into from Mar 17, 2014

Conversation

Projects
None yet
3 participants
Contributor

Fortisque commented Feb 18, 2014

Let errors get handled in the default way if an error occurs before
we start streaming. This reverts #14000 but offers a better fix.

matthewd referenced this pull request Mar 7, 2014

use built-in exception handling in live controllers
when an exception happens in an action before the response has been
committed, then we should re-raise the exception in the main thread.
This lets us reuse the existing exception handling.
Owner

tenderlove commented Mar 14, 2014

Can you rebase this patch?

Contributor

Fortisque commented Mar 14, 2014

Okay I rebased it, I think beside the variable name changes my patch just had these updates to the tests.

Owner

matthewd commented Mar 15, 2014

@Fortisque you had an 'else' that we want

Contributor

Fortisque commented Mar 15, 2014

Oh I see, I put the else back

Owner

matthewd commented Mar 15, 2014

Now the if/else bodies are the wrong way around 😄

Owner

matthewd commented Mar 17, 2014

👍

/ping @tenderlove

tenderlove added a commit that referenced this pull request Mar 17, 2014

Merge pull request #14090 from Fortisque/kevin/stream_error_in_main_t…
…hread_if_not_committed

re-raise error if error occurs before committing in streaming

@tenderlove tenderlove merged commit ba3ad25 into rails:master Mar 17, 2014

1 check passed

default The Travis CI build passed
Details

tenderlove added a commit that referenced this pull request Mar 18, 2014

Merge pull request #14090 from Fortisque/kevin/stream_error_in_main_t…
…hread_if_not_committed

re-raise error if error occurs before committing in streaming

tenderlove added a commit that referenced this pull request Mar 18, 2014

Merge pull request #14090 from Fortisque/kevin/stream_error_in_main_t…
…hread_if_not_committed

re-raise error if error occurs before committing in streaming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment