Add controller and action name to the fragment caching instrumentation payload#14137
Merged
rafaelfranca merged 1 commit intoMay 14, 2014
Merged
Conversation
Contributor
Author
|
@josevalim I've added some more instrumentation here – would you mind taking a look at it? |
Contributor
Author
|
@rafaelfranca @josevalim would you guys care to take a look at this? It's been sitting here for a while now, and I think it would be useful for people :-) |
Member
|
I don't see why we should not. Could you add a CHANGELOG entry? |
Contributor
Author
|
@rafaelfranca sure! I've pushed an updated commit. |
Member
There was a problem hiding this comment.
Could you please use 1.9 hash syntax here ?
rafaelfranca
added a commit
that referenced
this pull request
May 14, 2014
…ation Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows tracking the cache activity and performance separately for each controller action. For instance, it would be possible to calculate the cache hit rate for a specific action on a specific controller.
I'd like to add the virtual path of the template to the payload, but it doesn't appear to be accessible from within the module – and I'd rather not pass it explicitly from Action View. If you have any ideas, it would be much appreciated.