[ci skip] remove guide section on models in migrations #14208

Merged
merged 1 commit into from Feb 26, 2014

Conversation

Projects
None yet
3 participants
@lukesteensen
Contributor

lukesteensen commented Feb 26, 2014

Both examples given are incorrect, and no one can seem to come up with
a realistic situation where this is an actual problem. For now, it seems like
the best thing to do is just scrap the section altogether.

[ci skip] remove guide section on models in migrations
Both examples given are incorrect, and no one can seem to come up with
a realistic situation where this is an actual problem. For now, it seems like
the best thing to do is just scrap the section altogether.
@lukesteensen

This comment has been minimized.

Show comment
Hide comment
@lukesteensen

lukesteensen Feb 26, 2014

Contributor

/cc @fxn

fixes #11761

Contributor

lukesteensen commented Feb 26, 2014

/cc @fxn

fixes #11761

fxn added a commit that referenced this pull request Feb 26, 2014

Merge pull request #14208 from lukesteensen/remove-migration-example
[ci skip] remove guide section on models in migrations [ci skip]

@fxn fxn merged commit be97499 into rails:master Feb 26, 2014

@lukesteensen

This comment has been minimized.

Show comment
Hide comment
@lukesteensen

lukesteensen Feb 26, 2014

Contributor

Thanks @fxn!

Contributor

lukesteensen commented Feb 26, 2014

Thanks @fxn!

@lukesteensen lukesteensen deleted the lukesteensen:remove-migration-example branch Feb 26, 2014

@runephilosof

This comment has been minimized.

Show comment
Hide comment
@runephilosof

runephilosof Mar 13, 2015

This was useful information.
I don't see why the situations aren't realistic.
I have just had a problem because I didn't use models properly in a migration.
My migration failed when it was run with newer code that validated a field, which was not present for that migration.

This was useful information.
I don't see why the situations aren't realistic.
I have just had a problem because I didn't use models properly in a migration.
My migration failed when it was run with newer code that validated a field, which was not present for that migration.

This comment has been minimized.

Show comment
Hide comment
@runephilosof

runephilosof Mar 13, 2015

Could you reference a mailing list thread or similar that this was discussed in?

Could you reference a mailing list thread or similar that this was discussed in?

This comment has been minimized.

Show comment
Hide comment
@lukesteensen

lukesteensen Mar 16, 2015

Contributor

@runephilosof This was discussed in #14166

Contributor

lukesteensen replied Mar 16, 2015

@runephilosof This was discussed in #14166

smathy added a commit to smathy/rails that referenced this pull request Apr 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment