This should fix the 7 tests failing on master for ActiveRecord #1421

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

farleyknight commented May 31, 2011

This should fix the 7 tests failing on master for ActiveRecord

test_loading_the_association_target_should_keep_child_records_marked_for_destruction

The part object was divorced from the association, so the instance variable for mark_for_destruction could never be reached.

test_should_not_overwrite_unsaved_updates_when_loading_association and #test_should_not_remove_scheduled_destroys_when_loading_association

As far as I can tell, nested attributes are not enough to force a load of an association.

TestHasManyAutosaveAssociationWhichItselfHasAutosaveAssociations

Avoid accessing the association directly in setup, in light of the two test cases below it. Both of those cases had been loading the association directly, by mistake.

Member

arunagw commented May 31, 2011

These tests are passing with ruby-1.9.2-p180

Can you see this #1417

Contributor

farleyknight commented May 31, 2011

Yep, that works for me.

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

Fixed RFC-2045 quoted-printable bug [#1421 state:committed]
http://www.faqs.org/rfcs/rfc2045.html says:

          may be
          represented by an "=" followed by a two digit
          hexadecimal representation of the octet's value.  The
          digits of the hexadecimal alphabet, for this purpose,
          are "0123456789ABCDEF".  Uppercase letters must be
          used; lowercase letters are not allowed.

ActionMailer, however, used "=%02x" specification.

Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment